[PATCH yew-widget-toolkit 3/3] widget: input panel: correctly generate keys for custom children

[Dominik Csapak <d.csapak@proxmox.com>]

The input panel tries to extract a key from a custom child, but
generates one if it can't. This generated key accidentally only included
the `left_count` for its ID so two custom child (one on the left and one
on the right in the same row) would get the same key, which leads to
buggy and glitchy behavior (yews dom handling does not expect duplicate
keys).

Fix this by generating truly unique keys by including the row and column
position, as well as the advanced state, like we do for normal fields.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/widget/input_panel.rs | 49 ++++++++++++++++++++-------------------
 1 file changed, 25 insertions(+), 24 deletions(-)

diff --git a/src/widget/input_panel.rs b/src/widget/input_panel.rs
index 4c86bc4..d22049e 100644
--- a/src/widget/input_panel.rs
+++ b/src/widget/input_panel.rs
@@ -215,32 +215,33 @@ impl InputPanel {
             visible = false;
         }
 
-        let style = if visible {
-            let (row, start, span) = if self.mobile {
-                self.left_count += 1; // ignore position
-                (self.left_count, 1, -1)
-            } else {
-                match column {
-                    FieldPosition::Left => {
-                        self.left_count += 1;
-                        (self.left_count, 1, 3)
-                    }
-                    FieldPosition::Right => {
-                        self.two_column = true;
-                        self.right_count += 1;
-                        (self.right_count, 4, -1)
-                    }
-                    FieldPosition::Large => {
-                        self.two_column = true;
+        let (row, start, span) = if self.mobile {
+            self.left_count += 1; // ignore position
+            (self.left_count, 1, -1)
+        } else {
+            match column {
+                FieldPosition::Left => {
+                    self.left_count += 1;
+                    (self.left_count, 1, 3)
+                }
+                FieldPosition::Right => {
+                    self.two_column = true;
+                    self.right_count += 1;
+                    (self.right_count, 4, -1)
+                }
+                FieldPosition::Large => {
+                    self.two_column = true;
 
-                        let max = self.left_count.max(self.right_count);
-                        self.left_count = max + 1;
-                        self.right_count = max + 1;
+                    let max = self.left_count.max(self.right_count);
+                    self.left_count = max + 1;
+                    self.right_count = max + 1;
 
-                        (self.left_count, 1, -1)
-                    }
+                    (self.left_count, 1, -1)
                 }
-            };
+            }
+        };
+
+        let style = if visible {
             format!("grid-row: {}; grid-column: {}/{};", row, start, span)
         } else {
             "display: none;".to_string()
@@ -251,7 +252,7 @@ impl InputPanel {
             None => {
                 #[cfg(debug_assertions)]
                 log::warn!("could not extract key from custom child, generating one");
-                yew::virtual_dom::Key::from(format!("cl_{}", self.left_count))
+                Key::from(format!("c_{}_{}_{}", start, row, advanced))
             }
         };
 
-- 
2.47.3