From: Dominik Csapak <d.csapak@proxmox.com>
To: yew-devel@lists.proxmox.com
Subject: [PATCH yew-widget-toolkit 1/2] touch: slidable: properly use builder methods for style/css
Date: Tue, 9 Jun 2026 15:37:08 +0200 [thread overview]
Message-ID: <20260609133742.3249328-1-d.csapak@proxmox.com> (raw)
instead of constructing one big 'style' attribute, use the proper
builder methods, such as '.class()', '.width()', and so on.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/touch/slidable/mod.rs | 71 ++++++++++++++++++---------------------
1 file changed, 32 insertions(+), 39 deletions(-)
diff --git a/src/touch/slidable/mod.rs b/src/touch/slidable/mod.rs
index ae45e29..0b0a513 100644
--- a/src/touch/slidable/mod.rs
+++ b/src/touch/slidable/mod.rs
@@ -12,6 +12,7 @@ use yew::html::{IntoEventCallback, IntoPropValue};
use yew::prelude::*;
use yew::virtual_dom::VNode;
+use crate::css;
use crate::dom::DomSizeObserver;
use crate::prelude::*;
use crate::props::CssLength;
@@ -362,7 +363,7 @@ impl Component for PwtSlidable {
// no animation during drag
let transition = if self.drag_pos.is_none() {
- "transition: width 0.1s ease-out;"
+ "width 0.1s ease-out"
} else {
""
};
@@ -370,10 +371,10 @@ impl Component for PwtSlidable {
let upper = GestureDetector::new(
Container::new()
.class("pwt-slidable-slider")
- .attribute(
- "style",
- "touch-action:none;width:100%;flex:0 0 auto;overflow:hidden;",
- )
+ .class(css::Overflow::Hidden)
+ .flex(0.0)
+ .width(CssLength::Fraction(1.0))
+ .style("touch-action", "none")
.with_child(props.content.clone())
.into_html_with_ref(self.content_ref.clone()),
)
@@ -382,47 +383,39 @@ impl Component for PwtSlidable {
.on_swipe(ctx.link().callback(Msg::Swipe));
let left_container = Container::new()
- .attribute(
- "style",
- format!(
- "width:{left}px;flex: 0 0 auto;{};overflow:hidden;",
- transition
- ),
- )
+ .width(CssLength::Px(left))
+ .flex(0.0)
+ .class(css::Overflow::Hidden)
+ .style("transition", transition)
.with_child(self.left_container(ctx));
let right_container = Container::new()
- .attribute(
- "style",
- format!(
- "width:{right}px;flex: 0 0 auto;{};overflow:hidden;",
- transition
- ),
- )
+ .width(CssLength::Px(right))
+ .flex(0.0)
+ .class(css::Overflow::Hidden)
+ .style("transition", transition)
.with_child(self.right_container(ctx));
let row = Row::new()
- .attribute(
- "style",
- format!(
- "width:{};overflow:hidden;justify-content:{};transition:height 0.2s ease-out;{}",
- if self.start_pos == 0f64 && self.drag_pos.is_none() && !self.switch_back {
- String::from("100%")
- } else {
- format!("{}px", self.content_width)
- },
- if self.last_action_left {
- "left"
- } else {
- "right"
- },
- match self.view_state {
- ViewState::Normal => String::new(),
- ViewState::DismissStart => format!("height:{}px;", self.content_height),
- ViewState::DismissTransition | ViewState::Dismissed => String::from("height:0px;"),
- }
- ),
+ .width(
+ if self.start_pos == 0f64 && self.drag_pos.is_none() && !self.switch_back {
+ CssLength::Fraction(1.0)
+ } else {
+ CssLength::Px(self.content_width)
+ },
)
+ .class(css::Overflow::Hidden)
+ .class(if self.last_action_left {
+ css::JustifyContent::Left
+ } else {
+ css::JustifyContent::Right
+ })
+ .style("transition", "height 0.2s ease-out")
+ .height(match self.view_state {
+ ViewState::Normal => CssLength::None,
+ ViewState::DismissStart => CssLength::Px(self.content_height),
+ ViewState::DismissTransition | ViewState::Dismissed => CssLength::Px(0.0),
+ })
.with_child(left_container)
.with_child(upper)
.with_child(right_container)
--
2.47.3
next reply other threads:[~2026-06-09 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 13:37 Dominik Csapak [this message]
2026-06-09 13:37 ` [PATCH yew-widget-toolkit 2/2] touch: slidable: improve action interface Dominik Csapak
2026-06-09 16:50 ` applied: [PATCH yew-widget-toolkit 1/2] touch: slidable: properly use builder methods for style/css Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609133742.3249328-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox