public inbox for yew-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shannon Sterz <s.sterz@proxmox.com>
To: yew-devel@lists.proxmox.com
Subject: [PATCH yew-mobile-gui v2 07/21] tree-wide: remove unnecessary lazy evaluations
Date: Fri,  8 May 2026 17:57:08 +0200	[thread overview]
Message-ID: <20260508155722.464564-8-s.sterz@proxmox.com> (raw)
In-Reply-To: <20260508155722.464564-1-s.sterz@proxmox.com>

fixes the clippy lint "clippy::unnecessary_lazy_evaluations" [1].

[1]:
https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 src/pages/page_dashboard.rs                   | 2 +-
 src/pages/page_lxc_status/dashboard_panel.rs  | 2 +-
 src/pages/page_qemu_status/dashboard_panel.rs | 2 +-
 src/pages/page_resources.rs                   | 9 +++++----
 src/widgets/guest_backup_panel.rs             | 2 +-
 5 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/pages/page_dashboard.rs b/src/pages/page_dashboard.rs
index ff890ca..519b22e 100644
--- a/src/pages/page_dashboard.rs
+++ b/src/pages/page_dashboard.rs
@@ -216,7 +216,7 @@ impl PvePageDashboard {
                     icon_list_tile(
                         Fa::new("server").class(
                             (item.status == ClusterNodeIndexResponseStatus::Online)
-                                .then(|| "pwt-color-primary"),
+                                .then_some("pwt-color-primary"),
                         ),
                         nodename.clone(),
                         subtitle.to_string(),
diff --git a/src/pages/page_lxc_status/dashboard_panel.rs b/src/pages/page_lxc_status/dashboard_panel.rs
index e597116..00fec11 100644
--- a/src/pages/page_lxc_status/dashboard_panel.rs
+++ b/src/pages/page_lxc_status/dashboard_panel.rs
@@ -82,7 +82,7 @@ fn large_fa_icon(name: &str, running: bool) -> Fa {
     Fa::new(name)
         .fixed_width()
         .class("pwt-font-size-title-large")
-        .class(running.then(|| "pwt-color-primary"))
+        .class(running.then_some("pwt-color-primary"))
 }
 
 fn format_guest_task_confirmation(
diff --git a/src/pages/page_qemu_status/dashboard_panel.rs b/src/pages/page_qemu_status/dashboard_panel.rs
index 47aa89c..27098f4 100644
--- a/src/pages/page_qemu_status/dashboard_panel.rs
+++ b/src/pages/page_qemu_status/dashboard_panel.rs
@@ -85,7 +85,7 @@ fn large_fa_icon(name: &str, running: bool) -> Fa {
     Fa::new(name)
         .fixed_width()
         .class("pwt-font-size-title-large")
-        .class(running.then(|| "pwt-color-primary"))
+        .class(running.then_some("pwt-color-primary"))
 }
 
 fn format_guest_task_confirmation(
diff --git a/src/pages/page_resources.rs b/src/pages/page_resources.rs
index 1365d63..b20a8e2 100644
--- a/src/pages/page_resources.rs
+++ b/src/pages/page_resources.rs
@@ -117,7 +117,7 @@ impl PvePageResources {
         let nodename = item.node.clone().unwrap();
         icon_list_tile(
             Fa::new("server")
-                .class((item.status.as_deref() == Some("online")).then(|| "pwt-color-primary")),
+                .class((item.status.as_deref() == Some("online")).then_some("pwt-color-primary")),
             nodename.clone(),
             match item.level.as_deref() {
                 Some("") | None => "no subscription",
@@ -141,7 +141,7 @@ impl PvePageResources {
     fn create_vm_list_item(&self, icon: &str, item: &ClusterResource) -> ListTile {
         icon_list_tile(
             Fa::new(icon)
-                .class((item.status.as_deref() == Some("running")).then(|| "pwt-color-primary")),
+                .class((item.status.as_deref() == Some("running")).then_some("pwt-color-primary")),
             format!(
                 "{} {}",
                 item.vmid.unwrap(),
@@ -187,8 +187,9 @@ impl PvePageResources {
         let plugin_type = item.plugintype.clone().unwrap();
 
         let mut tile = icon_list_tile(
-            Fa::new("database")
-                .class((item.status.as_deref() == Some("available")).then(|| "pwt-color-primary")),
+            Fa::new("database").class(
+                (item.status.as_deref() == Some("available")).then_some("pwt-color-primary"),
+            ),
             format!("{} ({})", name, plugin_type),
             item.node.clone(),
             item.status.clone(),
diff --git a/src/widgets/guest_backup_panel.rs b/src/widgets/guest_backup_panel.rs
index fac281b..00f211e 100644
--- a/src/widgets/guest_backup_panel.rs
+++ b/src/widgets/guest_backup_panel.rs
@@ -158,7 +158,7 @@ impl PveGuestBackupPanel {
                         info.total,
                         info.used,
                     )
-                    .class(active.then(|| pwt::css::ColorScheme::PrimaryContainer))
+                    .class(active.then_some(pwt::css::ColorScheme::PrimaryContainer))
                     .class(if active {
                         "pwt-elevation4"
                     } else {
-- 
2.47.3





  parent reply	other threads:[~2026-05-08 15:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08 15:57 [PATCH yew-comp/yew-mobile-gui v2 00/21] firewall tabs and clean up for pve-yew-mobile-gui Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-comp v2 01/21] firewall rules panel: correct the url for the pve cluster firewall rules Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 02/21] cargo.toml: globally ignore certain clippy lints Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 03/21] main: avoid unnecessary clones Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 04/21] tree-wide: collapse if statements Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 05/21] tree-wide: implement the `From` trait instead of the `Into` trait Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 06/21] tree-wide: implement `Default` for types with an `new()` constructor Shannon Sterz
2026-05-08 15:57 ` Shannon Sterz [this message]
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 08/21] tree-wide: remove needless borrows Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 09/21] configuration page: remove redundant static lifetimes Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 10/21] resources/configuration page: remove useless `.into()` calls Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 11/21] tree-wide: fix several clippy lints Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 12/21] dashboard: use proper plural translation string instead of "CPU(s)" Shannon Sterz
2026-05-08 16:11   ` Shan Shaji
2026-05-08 16:13   ` Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 13/21] configuration: clarify that "Firewall" shows the cluster's firewall Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 14/21] cluster/qemu firewall: use rules panel and comment out unused tabs Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 15/21] qemu status page: align icons better with tabs Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 16/21] lxc page: align layout for lxc guest with qemu guests Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 17/21] lxc: add support for a rudimentary firewall tab for lxc guests Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 18/21] node status: align layout for node status with guest pages Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 19/21] node: add a rudimentary firewall tab for cluster nodes Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 20/21] api types: remove unused file Shannon Sterz
2026-05-08 15:57 ` [PATCH yew-mobile-gui v2 21/21] resources page: map subscription level analogous to dashboard Shannon Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260508155722.464564-8-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=yew-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal