From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 746B81FF14F for ; Fri, 08 May 2026 17:57:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 58A861D54E; Fri, 8 May 2026 17:57:35 +0200 (CEST) From: Shannon Sterz To: yew-devel@lists.proxmox.com Subject: [PATCH yew-mobile-gui v2 11/21] tree-wide: fix several clippy lints Date: Fri, 8 May 2026 17:57:12 +0200 Message-ID: <20260508155722.464564-12-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260508155722.464564-1-s.sterz@proxmox.com> References: <20260508155722.464564-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778255736181 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.116 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [main.rs] Message-ID-Hash: IXT43KQDI7MND2VQNUW76IUI755ZNRW7 X-Message-ID-Hash: IXT43KQDI7MND2VQNUW76IUI755ZNRW7 X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: this fixes the following clippy lints: * let_and_return * just_underscores_and_digits * manual_map * match_like_matches_macro * missing_const_for_thread_local * needless_return * redundant_closure * unnecessary_to_owned Signed-off-by: Shannon Sterz --- src/main.rs | 4 ++-- src/pages/page_configuartion.rs | 2 +- src/pages/page_qemu_status/dashboard_panel.rs | 5 ++--- src/pages/page_resources.rs | 4 ++-- src/widgets/task_list_button.rs | 21 +++++++------------ src/widgets/tasks_panel.rs | 2 +- 6 files changed, 16 insertions(+), 22 deletions(-) diff --git a/src/main.rs b/src/main.rs index 3b22e41..74d4044 100644 --- a/src/main.rs +++ b/src/main.rs @@ -344,12 +344,12 @@ impl Component for PveMobileApp { if auth { switch(path) } else { - return vec![ + vec![ PageLogin::new() .consent_text(consent_text.clone()) .on_login(link.callback(Msg::Login)) .into(), - ]; + ] } }; diff --git a/src/pages/page_configuartion.rs b/src/pages/page_configuartion.rs index 46077c8..73c9eac 100644 --- a/src/pages/page_configuartion.rs +++ b/src/pages/page_configuartion.rs @@ -72,7 +72,7 @@ impl PvePageConfiguration { List::new(CONFIGS.len() as u64, move |pos| { let item = CONFIGS[pos as usize]; - icon_list_tile(Fa::new(item.0.to_string()), item.1.to_string(), (), ()) + icon_list_tile(Fa::new(item.0), item.1.to_string(), (), ()) .interactive(true) .onclick({ let navigator = navigator.clone(); diff --git a/src/pages/page_qemu_status/dashboard_panel.rs b/src/pages/page_qemu_status/dashboard_panel.rs index 27098f4..dc5a8c5 100644 --- a/src/pages/page_qemu_status/dashboard_panel.rs +++ b/src/pages/page_qemu_status/dashboard_panel.rs @@ -336,9 +336,8 @@ impl Component for PveQemuDashboardPanel { if let Value::Object(map) = &mut data { map.retain(|_k, v| v != &Value::Null); } - let data = serde_json::from_value::(data) - .map_err(|err| err.into()); - data + + serde_json::from_value::(data).map_err(|err| err.into()) } Err(err) => Err(err), }; diff --git a/src/pages/page_resources.rs b/src/pages/page_resources.rs index fdd9af4..469bbf3 100644 --- a/src/pages/page_resources.rs +++ b/src/pages/page_resources.rs @@ -90,7 +90,7 @@ fn filter_match(item: &ClusterResource, filter: &ResourceFilter) -> bool { } thread_local! { - static RESOURCES: RefCell, Error>>> = RefCell::new(None); + static RESOURCES: RefCell, Error>>> = const { RefCell::new(None) }; } pub struct PvePageResources { reload_timeout: Option, @@ -303,7 +303,7 @@ impl PvePageResources { fn create_top_bar(&self, ctx: &Context) -> Html { let mut search = Field::new() .value(self.filter.name.clone()) - .on_change(ctx.link().callback(|value| Msg::SetTextFilter(value))) + .on_change(ctx.link().callback(Msg::SetTextFilter)) .class(pwt::css::Flex::Fill); search.add_trigger( diff --git a/src/widgets/task_list_button.rs b/src/widgets/task_list_button.rs index d449428..3b28162 100644 --- a/src/widgets/task_list_button.rs +++ b/src/widgets/task_list_button.rs @@ -133,12 +133,10 @@ impl Component for ProxmoxTaskListButton { if Some(&upid) != self.running_upid.as_ref() { return false; } - let running = match &result { - Ok(status) if status.status == IsRunning::Running => true, - _ => false, - }; - if running { + if let Ok(status) = &result + && status.status == IsRunning::Running + { let link = ctx.link().clone(); self.check_task_status_timeout = Some(Timeout::new(1000, move || { link.send_message(Msg::CheckTaskStatus); @@ -165,14 +163,11 @@ impl Component for ProxmoxTaskListButton { fn view(&self, ctx: &Context) -> Html { let props = ctx.props(); - let content = match &self.last_task_status { - Some(last_task_status) => Some( - Container::new() - .class("pwt-font-size-title-medium") - .with_child(last_task_status), - ), - None => None, - }; + let content = self.last_task_status.as_ref().map(|last_task_status| { + Container::new() + .class("pwt-font-size-title-medium") + .with_child(last_task_status) + }); Column::new() .gap(2) diff --git a/src/widgets/tasks_panel.rs b/src/widgets/tasks_panel.rs index 36f8c29..326aaef 100644 --- a/src/widgets/tasks_panel.rs +++ b/src/widgets/tasks_panel.rs @@ -57,7 +57,7 @@ fn task_icon(task: &ListTasksResponse) -> Fa { match task.status.as_deref() { Some("OK") => Fa::new("info-circle").class(pwt::css::FontColor::Primary), - Some(__) => Fa::new("exclamation-triangle").class(pwt::css::FontColor::Error), + Some(_) => Fa::new("exclamation-triangle").class(pwt::css::FontColor::Error), _ => Fa::new("question"), } } -- 2.47.3