From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id AB63C1FF13B for ; Wed, 25 Mar 2026 12:44:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 070D715EF4; Wed, 25 Mar 2026 12:44:40 +0100 (CET) From: Shannon Sterz To: yew-devel@lists.proxmox.com Subject: [PATCH yew-comp] auth view: don't mark realm sync dialog as "edit" and set submit text Date: Wed, 25 Mar 2026 12:43:35 +0100 Message-ID: <20260325114334.137252-2-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774439029340 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.121 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UQE2S2Y7572QSNWED7VOPTRZGMGPLZ3G X-Message-ID-Hash: UQE2S2Y7572QSNWED7VOPTRZGMGPLZ3G X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: previously it was not possible to submit this window without making any changes since setting a loader marked the window as being in "edit mode". leading to the paradoxical scenario where running a sync job with the default settings for that realm wasn't possible. change this behaviour by marking the `EditWindow` as not being in "edit mode" and setting a more appropriate text for the submit button. the side-effect of this is that the reset button is no longer available, but that is deemed preferable over not being able to sync with a realm's default configuration. Signed-off-by: Shannon Sterz --- Notes: it might be preferable to split up behaviour here. maybe whether the reset button is rendered and "check_dirty" is enabled on the submit button should be separate settings. but that would have had wider implications across our ecosystem, so i opted for this smaller set of changes here. src/auth_view.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/auth_view.rs b/src/auth_view.rs index 7a88f4c..9a06979 100644 --- a/src/auth_view.rs +++ b/src/auth_view.rs @@ -469,6 +469,8 @@ impl LoadableComponent for ProxmoxAuthView { format!("{base_url}/{}", percent_encode_component(&realm.realm)); move || load_realm(url.clone()) }) + .edit(false) + .submit_text(tr!("Start Sync")) .submit_digest(false) .on_close(link.change_view_callback(|_| None)) .on_submit(move |form_context| { -- 2.47.3