From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 90E591FF178 for ; Fri, 06 Mar 2026 12:21:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 34F5A1FA99; Fri, 6 Mar 2026 12:22:28 +0100 (CET) From: Shannon Sterz To: yew-devel@lists.proxmox.com Subject: [PATCH yew-comp 06/15] tree wide: fix clippy lint "clone_on_copy" Date: Fri, 6 Mar 2026 12:21:38 +0100 Message-ID: <20260306112148.208189-7-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260306112148.208189-1-s.sterz@proxmox.com> References: <20260306112148.208189-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772796082529 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.402 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLACK 3 Contains an URL listed in the URIBL blacklist [rust-lang.github.io] Message-ID-Hash: GFLUJLNPGOHN6KYSNPWNMNA4VQUSFMYK X-Message-ID-Hash: GFLUJLNPGOHN6KYSNPWNMNA4VQUSFMYK X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: see: https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy Signed-off-by: Shannon Sterz --- src/form/pve/lxc_property/lxc_mount_point_property.rs | 2 +- src/form/pve/pve_guest_selector.rs | 4 ++-- src/form/pve/pve_storage_content_selector.rs | 6 +++--- src/form/pve/qemu_disk_format_selector.rs | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/form/pve/lxc_property/lxc_mount_point_property.rs b/src/form/pve/lxc_property/lxc_mount_point_property.rs index c0dd36f..379577d 100644 --- a/src/form/pve/lxc_property/lxc_mount_point_property.rs +++ b/src/form/pve/lxc_property/lxc_mount_point_property.rs @@ -416,7 +416,7 @@ fn mount_point_property( move |mut record: Value| { let used_mount_points = extract_used_mount_points(&record); let default_mount_point = first_unused_mount_point(&used_mount_points); - record[MOUNT_POINT_ID] = default_mount_point.clone().into(); + record[MOUNT_POINT_ID] = default_mount_point.into(); if unused_disk.is_none() { if let Some(name) = &name { diff --git a/src/form/pve/pve_guest_selector.rs b/src/form/pve/pve_guest_selector.rs index f4ff7ab..e1fcf2d 100644 --- a/src/form/pve/pve_guest_selector.rs +++ b/src/form/pve/pve_guest_selector.rs @@ -141,8 +141,8 @@ impl PveGuestSelectorComp { let props = ctx.props(); let remote = props.remote.clone(); let guest_type = props.guest_type; - let templates = props.templates.clone(); - let exclude_guest = props.exclude_guest.clone(); + let templates = props.templates; + let exclude_guest = props.exclude_guest; (move || Self::get_guest_list(remote.clone(), guest_type, exclude_guest, templates)).into() } } diff --git a/src/form/pve/pve_storage_content_selector.rs b/src/form/pve/pve_storage_content_selector.rs index fdb3d96..9151851 100644 --- a/src/form/pve/pve_storage_content_selector.rs +++ b/src/form/pve/pve_storage_content_selector.rs @@ -126,15 +126,15 @@ impl PveStorageContentSelectorComp { let props = ctx.props(); let node = props.node.clone(); let storage = props.storage.clone(); - let content_filter = props.content_filter.clone(); + let content_filter = props.content_filter; let vmid_filter = props.vmid_filter; (move || { Self::get_storage_content( node.clone().unwrap_or("localhost".into()), storage.clone(), - content_filter.clone(), - vmid_filter.clone(), + content_filter, + vmid_filter, ) }) .into() diff --git a/src/form/pve/qemu_disk_format_selector.rs b/src/form/pve/qemu_disk_format_selector.rs index 5b26d2f..99d3642 100644 --- a/src/form/pve/qemu_disk_format_selector.rs +++ b/src/form/pve/qemu_disk_format_selector.rs @@ -147,7 +147,7 @@ impl Component for QemuDiskFormatComp { .read() .iter() .find(|item| *item.format_text == *key) - .map(|entry| entry.format.clone()); + .map(|entry| entry.format); if let Some(on_change) = &on_change { on_change.emit(format); -- 2.47.3