From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 16F2B1FF178 for ; Fri, 06 Mar 2026 12:21:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D9D871FADB; Fri, 6 Mar 2026 12:22:29 +0100 (CET) From: Shannon Sterz To: yew-devel@lists.proxmox.com Subject: [PATCH yew-comp 09/15] tree wide: fix clippy lint "manual_strip" Date: Fri, 6 Mar 2026 12:21:41 +0100 Message-ID: <20260306112148.208189-10-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260306112148.208189-1-s.sterz@proxmox.com> References: <20260306112148.208189-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772796082841 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.397 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLACK 3 Contains an URL listed in the URIBL blacklist [rust-lang.github.io] Message-ID-Hash: HH4R4SMYBKEURFD2NR4GYMZYS5UUM7TO X-Message-ID-Hash: HH4R4SMYBKEURFD2NR4GYMZYS5UUM7TO X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: see: https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip Signed-off-by: Shannon Sterz --- .../pve/lxc_property/lxc_network_property.rs | 4 ++-- src/form/pve/mod.rs | 4 ++-- src/form/pve/qemu_cpu_flags_list.rs | 8 ++++---- src/form/pve/qemu_machine_version_selector.rs | 18 ++++++++++-------- 4 files changed, 18 insertions(+), 16 deletions(-) diff --git a/src/form/pve/lxc_property/lxc_network_property.rs b/src/form/pve/lxc_property/lxc_network_property.rs index d33267b..f3e582a 100644 --- a/src/form/pve/lxc_property/lxc_network_property.rs +++ b/src/form/pve/lxc_property/lxc_network_property.rs @@ -43,8 +43,8 @@ fn get_schema(name: &str) -> &'static Schema { } fn net_property_id(name: &str) -> Option { - if name.starts_with("net") { - if let Ok(id) = name[3..].parse::() { + if let Some(name) = name.strip_prefix("net") { + if let Ok(id) = name.parse::() { return Some(id); } } diff --git a/src/form/pve/mod.rs b/src/form/pve/mod.rs index 0be5e6f..c92530a 100644 --- a/src/form/pve/mod.rs +++ b/src/form/pve/mod.rs @@ -88,8 +88,8 @@ pub enum PveGuestType { } fn parse_unused_key(key: &str) -> Option { - if key.starts_with("unused") { - if let Ok(id) = key[6..].parse::() { + if let Some(key) = key.strip_prefix("unused") { + if let Ok(id) = key.parse::() { return Some(id); } } diff --git a/src/form/pve/qemu_cpu_flags_list.rs b/src/form/pve/qemu_cpu_flags_list.rs index 048e268..bfcac50 100644 --- a/src/form/pve/qemu_cpu_flags_list.rs +++ b/src/form/pve/qemu_cpu_flags_list.rs @@ -55,10 +55,10 @@ fn parse_flags(flags: &str) -> HashMap { .filter_map(|flag| { if flag.is_empty() { None - } else if flag.starts_with("+") { - Some((flag[1..].to_string(), true)) - } else if flag.starts_with("-") { - Some((flag[1..].to_string(), false)) + } else if let Some(flag) = flag.strip_prefix("+") { + Some((flag.to_string(), true)) + } else if let Some(flag) = flag.strip_prefix("-") { + Some((flag.to_string(), false)) } else { log::error!("unable to parse cpu flag '{flag}' - missing prefix"); None diff --git a/src/form/pve/qemu_machine_version_selector.rs b/src/form/pve/qemu_machine_version_selector.rs index 746aba7..d8a3640 100644 --- a/src/form/pve/qemu_machine_version_selector.rs +++ b/src/form/pve/qemu_machine_version_selector.rs @@ -173,18 +173,20 @@ fn extract_version_text(id: &str) -> String { if id == "pc" || id == "q35" { return tr!("Latest"); } - if id.starts_with("pc-q35-") { - return id[7..].to_string(); + + if let Some(id) = id.strip_prefix("pc-q35-") { + return id.to_string(); } - if id.starts_with("pc-i440fx-") { - return id[10..].to_string(); + if let Some(id) = id.strip_prefix("pc-i440fx-") { + return id.to_string(); } - if id.starts_with("pc-") { - return id[3..].to_string(); + if let Some(id) = id.strip_prefix("pc-") { + return id.to_string(); } - if id.starts_with("virt-") { - return id[5..].to_string(); + if let Some(id) = id.strip_prefix("virt-") { + return id.to_string(); } + id.to_string() } -- 2.47.3