From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 231FE1FF165 for ; Thu, 28 Aug 2025 10:33:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7936BA9C8; Thu, 28 Aug 2025 10:33:14 +0200 (CEST) From: Dominik Csapak To: yew-devel@lists.proxmox.com Date: Thu, 28 Aug 2025 10:32:32 +0200 Message-ID: <20250828083240.1338864-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [yew-devel] [PATCH yew-widget-toolkit] widget: tab panel: fix tab bar bottom border X-BeenThere: yew-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Yew framework devel list at Proxmox List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yew framework devel list at Proxmox Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: yew-devel-bounces@lists.proxmox.com Sender: "yew-devel" commit: 028af44 (pwt-tab-material: do not set flex property) in pwt-assets removed the flex property from the css class of the tab bar, because we also use the tab bar outside of the tab panel sometimes (and the flex layout is not always correct there) later, wrong layout was noticed, but only when scroll-mode was set to `None` by commit: 4aad755 (fix tab panel layout when scroll_mode is None) We actually want to set the flex property with every scroll mode, otherwise the bottom border of the tab bar does not fill all the way to the right with tab panels. Signed-off-by: Dominik Csapak --- src/widget/tab/tab_panel.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/widget/tab/tab_panel.rs b/src/widget/tab/tab_panel.rs index 642df54..cd8bce9 100644 --- a/src/widget/tab/tab_panel.rs +++ b/src/widget/tab/tab_panel.rs @@ -2,13 +2,13 @@ use yew::html::IntoPropValue; use yew::prelude::*; use yew::virtual_dom::{Key, VList, VNode}; -use crate::prelude::*; use crate::props::{IntoOptionalInlineHtml, IntoStorageLocation, StorageLocation}; use crate::state::Selection; use crate::widget::{ Column, MiniScroll, MiniScrollMode, SelectionView, SelectionViewRenderInfo, TabBar, TabBarItem, TabBarStyle, }; +use crate::{css, prelude::*}; use pwt_macros::{builder, widget}; @@ -225,7 +225,7 @@ impl Component for PwtTabPanel { .selection(self.selection.clone()) .style(props.tab_bar_style) .state_id(props.state_id.clone()) - .class(props.scroll_mode.is_none().then(|| "pwt-flex-fill")) + .class(css::Flex::Fill) .into(); if let Some(scroll_mode) = props.scroll_mode { -- 2.47.2 _______________________________________________ yew-devel mailing list yew-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel