From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <yew-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id CA6381FF27A
for <inbox@lore.proxmox.com>; Fri, 30 May 2025 14:22:49 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id C8DD32E9A9;
Fri, 30 May 2025 14:23:05 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: yew-devel@lists.proxmox.com
Date: Fri, 30 May 2025 14:21:49 +0200
Message-Id: <20250530122202.2779300-8-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250530122202.2779300-1-d.csapak@proxmox.com>
References: <20250530122202.2779300-1-d.csapak@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.022 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [yew-devel] [PATCH yew-comp 07/20] rrd: remove unnecessary
`no_data` field
X-BeenThere: yew-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Yew framework devel list at Proxmox <yew-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/yew-devel>,
<mailto:yew-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/yew-devel/>
List-Post: <mailto:yew-devel@lists.proxmox.com>
List-Help: <mailto:yew-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel>,
<mailto:yew-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Yew framework devel list at Proxmox <yew-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: yew-devel-bounces@lists.proxmox.com
Sender: "yew-devel" <yew-devel-bounces@lists.proxmox.com>
just use slices, then we can return an empty slice here.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/rrd/graph.rs | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/rrd/graph.rs b/src/rrd/graph.rs
index 8b31103..e1eb9c9 100644
--- a/src/rrd/graph.rs
+++ b/src/rrd/graph.rs
@@ -143,7 +143,6 @@ pub struct PwtRRDGraph {
datapoint_ref: NodeRef,
align_options: AlignOptions,
y_label_ref: NodeRef,
- no_data: Vec<f64>,
serie0_visible: bool,
serie1_visible: bool,
}
@@ -359,12 +358,12 @@ impl PwtRRDGraph {
let time_data = &props.time_data;
let serie0_data = match (self.serie0_visible, &props.serie0) {
- (true, Some(serie)) => &serie.data,
- _ => &self.no_data,
+ (true, Some(serie)) => &serie.data[..],
+ _ => &[],
};
let serie1_data = match (self.serie1_visible, &props.serie1) {
- (true, Some(serie)) => &serie.data,
- _ => &self.no_data,
+ (true, Some(serie)) => &serie.data[..],
+ _ => &[],
};
if let Some((start, end)) = self.view_range {
@@ -697,7 +696,6 @@ impl Component for PwtRRDGraph {
datapoint_ref: NodeRef::default(),
align_options,
y_label_ref: NodeRef::default(),
- no_data: Vec::new(),
serie0_visible: true,
serie1_visible: true,
}
--
2.39.5
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel