From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <yew-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id E001C1FF27A
for <inbox@lore.proxmox.com>; Fri, 30 May 2025 14:22:19 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id D21472E6FE;
Fri, 30 May 2025 14:22:35 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: yew-devel@lists.proxmox.com
Date: Fri, 30 May 2025 14:21:53 +0200
Message-Id: <20250530122202.2779300-12-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250530122202.2779300-1-d.csapak@proxmox.com>
References: <20250530122202.2779300-1-d.csapak@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.022 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [yew-devel] [PATCH yew-comp 11/20] rrd: simplify toggle Msg
X-BeenThere: yew-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Yew framework devel list at Proxmox <yew-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/yew-devel>,
<mailto:yew-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/yew-devel/>
List-Post: <mailto:yew-devel@lists.proxmox.com>
List-Help: <mailto:yew-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel>,
<mailto:yew-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Yew framework devel list at Proxmox <yew-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: yew-devel-bounces@lists.proxmox.com
Sender: "yew-devel" <yew-devel-bounces@lists.proxmox.com>
by just accepting an idx instead of doing both series separately.
This also prepares that part of the code for more than 2 series.
While at it, fix the typo (Toogle -> Toggle).
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/rrd/graph.rs | 29 ++++++++++++++---------------
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/src/rrd/graph.rs b/src/rrd/graph.rs
index 7f02274..e011c21 100644
--- a/src/rrd/graph.rs
+++ b/src/rrd/graph.rs
@@ -125,8 +125,7 @@ pub enum Msg {
PointerEnter,
PointerLeave,
ClearViewRange,
- ToogleSerie0,
- ToogleSerie1,
+ ToggleSeries(u32), // index
}
pub struct PwtRRDGraph {
@@ -719,17 +718,17 @@ impl Component for PwtRRDGraph {
}
true
}
- Msg::ToogleSerie0 => {
- self.serie0_visible = !self.serie0_visible;
- if !(self.serie0_visible || self.serie1_visible) {
- self.serie1_visible = true;
- }
- true
- }
- Msg::ToogleSerie1 => {
- self.serie1_visible = !self.serie1_visible;
- if !(self.serie0_visible || self.serie1_visible) {
- self.serie0_visible = true;
+ Msg::ToggleSeries(idx) => {
+ if idx == 0 {
+ self.serie0_visible = !self.serie0_visible;
+ if !(self.serie0_visible || self.serie1_visible) {
+ self.serie1_visible = true;
+ }
+ } else if idx == 1 {
+ self.serie1_visible = !self.serie1_visible;
+ if !(self.serie0_visible || self.serie1_visible) {
+ self.serie0_visible = true;
+ }
}
true
}
@@ -880,7 +879,7 @@ impl Component for PwtRRDGraph {
Button::new(serie0.label.clone())
.class("pwt-button-elevated")
.icon_class(icon_class0)
- .onclick(ctx.link().callback(|_| Msg::ToogleSerie0)),
+ .onclick(ctx.link().callback(|_| Msg::ToggleSeries(0))),
);
let icon_class1 = classes!(
"pwt-rrd-legend-marker1",
@@ -892,7 +891,7 @@ impl Component for PwtRRDGraph {
Button::new(serie1.label.clone())
.class("pwt-button-elevated")
.icon_class(icon_class1)
- .onclick(ctx.link().callback(|_| Msg::ToogleSerie1)),
+ .onclick(ctx.link().callback(|_| Msg::ToggleSeries(1))),
);
}
}
--
2.39.5
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel