From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <yew-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 8EBA41FF189
for <inbox@lore.proxmox.com>; Thu, 22 May 2025 13:31:10 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 889EA34374;
Thu, 22 May 2025 13:31:13 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: yew-devel@lists.proxmox.com
Date: Thu, 22 May 2025 13:31:09 +0200
Message-Id: <20250522113110.1986398-3-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250522113110.1986398-1-d.csapak@proxmox.com>
References: <20250522113110.1986398-1-d.csapak@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.021 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [yew-devel] [PATCH yew-widget-toolkit 3/4] input panel: use the
labels tags 'for' property for fields
X-BeenThere: yew-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Yew framework devel list at Proxmox <yew-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/yew-devel>,
<mailto:yew-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/yew-devel/>
List-Post: <mailto:yew-devel@lists.proxmox.com>
List-Help: <mailto:yew-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel>,
<mailto:yew-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Yew framework devel list at Proxmox <yew-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: yew-devel-bounces@lists.proxmox.com
Sender: "yew-devel" <yew-devel-bounces@lists.proxmox.com>
that way we get some nice default browser behavior when clicking on
labels that belong to a field.
When not using the InputPanel, one hast to manually connect the field
and label with their ids.
We want to use prevent_default in the labels onpointerdown event, so we
can prevent the field from losing focus, which would introduce a glitch
for e.g. comoboxes.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/widget/field_label.rs | 4 ++++
src/widget/input_panel.rs | 9 +++++++--
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/widget/field_label.rs b/src/widget/field_label.rs
index e773cc0..164c02f 100644
--- a/src/widget/field_label.rs
+++ b/src/widget/field_label.rs
@@ -34,6 +34,10 @@ impl Component for PwtFieldLabel {
Container::from_tag("label")
.with_std_props(&props.std_props)
.listeners(&props.listeners)
+ .onpointerdown(|event: PointerEvent| {
+ // prevents stealing focus from the input field
+ event.prevent_default();
+ })
.with_child(props.label.clone())
.into()
}
diff --git a/src/widget/input_panel.rs b/src/widget/input_panel.rs
index 06d8c6b..924f82d 100644
--- a/src/widget/input_panel.rs
+++ b/src/widget/input_panel.rs
@@ -216,7 +216,11 @@ impl InputPanel {
};
let label_id = crate::widget::get_unique_element_id();
- let mut label: FieldLabel = label.into().id(label_id.clone());
+ let field_id = crate::widget::get_unique_element_id();
+ let mut label: FieldLabel = label
+ .into()
+ .attribute("for", field_id.clone())
+ .id(label_id.clone());
if label.std_props.key.is_none() {
label.set_key(format!("label_{}", label.label));
}
@@ -229,7 +233,8 @@ impl InputPanel {
self.add_child(label.class(class).attribute("style", style.clone()));
let name = field.as_input_props().name.clone();
- let field = field.label_id(label_id).into();
+ let field = field.label_id(label_id).id(field_id).into();
+
let key = match field.key() {
Some(key) => key.clone(),
None => match name {
--
2.39.5
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel