From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <yew-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id EB5B71FF1C0
for <inbox@lore.proxmox.com>; Tue, 6 May 2025 14:45:03 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id D5D6DA419;
Tue, 6 May 2025 14:45:20 +0200 (CEST)
From: Shannon Sterz <s.sterz@proxmox.com>
To: yew-devel@lists.proxmox.com
Date: Tue, 6 May 2025 14:44:45 +0200
Message-Id: <20250506124445.196798-3-s.sterz@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250506124445.196798-1-s.sterz@proxmox.com>
References: <20250506124445.196798-1-s.sterz@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.017 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [store.rs]
Subject: [yew-devel] [PATCH yew-widget-toolkit v2 2/2] store: add try_read()
and try_write() functions
X-BeenThere: yew-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Yew framework devel list at Proxmox <yew-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/yew-devel>,
<mailto:yew-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/yew-devel/>
List-Post: <mailto:yew-devel@lists.proxmox.com>
List-Help: <mailto:yew-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel>,
<mailto:yew-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Yew framework devel list at Proxmox <yew-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: yew-devel-bounces@lists.proxmox.com
Sender: "yew-devel" <yew-devel-bounces@lists.proxmox.com>
these let users of the store decide whether failure to acquire a lock
on a store is critical enough to panic or whether this scenario can be
handled just fine.
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
src/state/store.rs | 37 ++++++++++++++++++++++++-------------
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/src/state/store.rs b/src/state/store.rs
index 67e72b77..42cb53b3 100644
--- a/src/state/store.rs
+++ b/src/state/store.rs
@@ -3,6 +3,7 @@ use std::ops::Range;
use std::ops::{Deref, DerefMut};
use std::rc::Rc;
+use anyhow::Error;
use derivative::Derivative;
use slab::Slab;
@@ -129,12 +130,18 @@ impl<T: 'static> Store<T> {
///
/// Panics if the value is currently mutably locked.
pub fn read(&self) -> StoreReadGuard<T> {
- StoreReadGuard {
- state: self
- .inner
- .try_borrow()
- .expect("Could not acquire read lock on store!"),
- }
+ self.try_read()
+ .expect("Could not acquire read lock on store!")
+ }
+
+ /// Try to lock this store for read access.
+ ///
+ /// Will return an error if the lock could not be acquired due to a write lock still being in
+ /// place.
+ pub fn try_read(&self) -> Result<StoreReadGuard<T>, Error> {
+ Ok(StoreReadGuard {
+ state: self.inner.try_borrow()?,
+ })
}
/// Lock this store for write access.
@@ -145,15 +152,19 @@ impl<T: 'static> Store<T> {
/// When the returned [StoreWriteGuard] is dropped, the store listeners
/// are notified. To prevent that use [StoreWriteGuard::skip_update]
pub fn write(&self) -> StoreWriteGuard<T> {
- let state = self
- .inner
- .try_borrow_mut()
- .expect("Could not acquire write lock on store!");
+ self.try_write()
+ .expect("Could not acquire write lock on store!")
+ }
- StoreWriteGuard {
- state,
+ /// Try to lock this store for write access.
+ ///
+ /// Will return an error if the lock could not be acquired due to a read or write lock still
+ /// being in place.
+ pub fn try_write(&self) -> Result<StoreWriteGuard<T>, Error> {
+ Ok(StoreWriteGuard {
+ state: self.inner.try_borrow_mut()?,
update: true,
- }
+ })
}
// DataStore trait implementation, so that we can use those
--
2.39.5
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel