[yew-devel] [PATCH yew-widget-toolkit] dialog: put all dialogs into a portal

[yew-devel] [PATCH yew-widget-toolkit] dialog: put all dialogs into a portal

[Dominik Csapak]

otherwise, the dialog is part of the markup where we insert it, which
can make problems with event handling, for example:

Creating a form that can open a dialog which contains also a form,
produces two problems:

* nesting forms is explicitly not allowed [0]
* if the form has a 'submit' input, pressing 'enter' in either form
  will submit the upper one.

To fix such issues in general, put the dialog into portal, which
put it directly into the body, where it can't interfere with other
elements up the tree. The yew component tree is not affected.

0: https://html.spec.whatwg.org/multipage/forms.html#the-form-element

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
this relies on my previous patch:
https://lore.proxmox.com/yew-devel/20250502124951.3886328-1-d.csapak@proxmox.com/

during my tests, i did not run into any problems, but this change
warrants longer tests, since it's a relatively big change in dom markup.

 src/widget/dialog.rs | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/widget/dialog.rs b/src/widget/dialog.rs
index aba77cc..6f492ff 100644
--- a/src/widget/dialog.rs
+++ b/src/widget/dialog.rs
@@ -12,7 +12,7 @@ use yew::prelude::*;
 use yew::virtual_dom::{Key, VComp, VNode};
 
 use crate::dom::align::{align_to_viewport, align_to_xy, Point};
-use crate::dom::{get_document, get_window, IntoHtmlElement};
+use crate::dom::{get_body, get_document, get_window, IntoHtmlElement};
 use crate::prelude::*;
 use crate::props::{AsCssStylesMut, CssStyles};
 use crate::widget::{ActionIcon, Panel};
@@ -500,7 +500,7 @@ impl Component for PwtDialog {
 
         let style = props.styles.compile_style_attribute(None);
 
-        html! {
+        let dialog = html! {
             <dialog class={"pwt-outer-dialog"} {onpointerdown} aria-label={props.title.clone()} ref={props.node_ref.clone()} {oncancel} {onclose} >
                 <div class={classes} {style} ref={self.inner_ref.clone()}>
                 {panel}
@@ -516,7 +516,9 @@ impl Component for PwtDialog {
                 }
                 </div>
             </dialog>
-        }
+        };
+
+        create_portal(dialog, get_body().into())
     }
 
     fn rendered(&mut self, ctx: &Context<Self>, first_render: bool) {
-- 
2.39.5



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel