From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3BCD41FF165 for ; Wed, 29 Jan 2025 10:42:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 68D371D603; Wed, 29 Jan 2025 10:42:05 +0100 (CET) From: Dominik Csapak To: yew-devel@lists.proxmox.com Date: Wed, 29 Jan 2025 10:42:00 +0100 Message-Id: <20250129094200.811682-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250129094200.811682-1-d.csapak@proxmox.com> References: <20250129094200.811682-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [selection.rs] Subject: [yew-devel] [PATCH yew-widget-toolkit 2/2] state: selection: make selection interface more consistent X-BeenThere: yew-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Yew framework devel list at Proxmox List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yew framework devel list at Proxmox Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: yew-devel-bounces@lists.proxmox.com Sender: "yew-devel" due to the interior mutability of th Selection (it uses Rc>), we don't need the selection to be mutable when we select something. This is reflected in in the interface for e.g. `select()` and `toggle()` which only take a `&self`. For `bulk_select()` the same logic can be applied, but it still took a `&mut self` which was not a problem, but it was unnecessary. To make it more consistent, simply change from `&mut self` to `&self`. Signed-off-by: Dominik Csapak --- src/state/selection.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/state/selection.rs b/src/state/selection.rs index 21e8e85..6866436 100644 --- a/src/state/selection.rs +++ b/src/state/selection.rs @@ -151,7 +151,7 @@ impl Selection { /// # Panics /// /// If multiselect is false. - pub fn bulk_select(&mut self, map: HashSet) { + pub fn bulk_select(&self, map: HashSet) { self.inner.borrow_mut().bulk_select(map); self.notify_listeners(); } -- 2.39.5 _______________________________________________ yew-devel mailing list yew-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel