* [yew-devel] [PATCH yew-widget-toolkit 1/2] widget: menu button: actually use 'disabled' property
@ 2025-01-29 9:41 Dominik Csapak
2025-01-29 9:42 ` [yew-devel] [PATCH yew-widget-toolkit 2/2] state: selection: make selection interface more consistent Dominik Csapak
2025-01-29 12:10 ` [yew-devel] applied: [PATCH yew-widget-toolkit 1/2] widget: menu button: actually use 'disabled' property Dietmar Maurer
0 siblings, 2 replies; 3+ messages in thread
From: Dominik Csapak @ 2025-01-29 9:41 UTC (permalink / raw)
To: yew-devel
namely for the top level button, otherwise the disabled property has no
effect.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
| 1 +
1 file changed, 1 insertion(+)
--git a/src/widget/menu/menu_button.rs b/src/widget/menu/menu_button.rs
index 50f85b3..2e2ed7f 100644
--- a/src/widget/menu/menu_button.rs
+++ b/src/widget/menu/menu_button.rs
@@ -248,6 +248,7 @@ impl Component for PwtMenuButton {
let mut button = Button::new(&props.text)
.show_arrow(props.show_arrow)
+ .disabled(props.disabled)
.attribute("aria-haspopup", "true")
.attribute("aria-expanded", self.show_submenu.then_some("true"))
.tabindex(props.tabindex)
--
2.39.5
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [yew-devel] [PATCH yew-widget-toolkit 2/2] state: selection: make selection interface more consistent
2025-01-29 9:41 [yew-devel] [PATCH yew-widget-toolkit 1/2] widget: menu button: actually use 'disabled' property Dominik Csapak
@ 2025-01-29 9:42 ` Dominik Csapak
2025-01-29 12:10 ` [yew-devel] applied: [PATCH yew-widget-toolkit 1/2] widget: menu button: actually use 'disabled' property Dietmar Maurer
1 sibling, 0 replies; 3+ messages in thread
From: Dominik Csapak @ 2025-01-29 9:42 UTC (permalink / raw)
To: yew-devel
due to the interior mutability of th Selection (it uses Rc<RefCell<>>),
we don't need the selection to be mutable when we select something. This
is reflected in in the interface for e.g. `select()` and `toggle()`
which only take a `&self`. For `bulk_select()` the same logic can be
applied, but it still took a `&mut self` which was not a problem, but it
was unnecessary. To make it more consistent, simply change from `&mut
self` to `&self`.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/state/selection.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/state/selection.rs b/src/state/selection.rs
index 21e8e85..6866436 100644
--- a/src/state/selection.rs
+++ b/src/state/selection.rs
@@ -151,7 +151,7 @@ impl Selection {
/// # Panics
///
/// If multiselect is false.
- pub fn bulk_select(&mut self, map: HashSet<Key>) {
+ pub fn bulk_select(&self, map: HashSet<Key>) {
self.inner.borrow_mut().bulk_select(map);
self.notify_listeners();
}
--
2.39.5
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [yew-devel] applied: [PATCH yew-widget-toolkit 1/2] widget: menu button: actually use 'disabled' property
2025-01-29 9:41 [yew-devel] [PATCH yew-widget-toolkit 1/2] widget: menu button: actually use 'disabled' property Dominik Csapak
2025-01-29 9:42 ` [yew-devel] [PATCH yew-widget-toolkit 2/2] state: selection: make selection interface more consistent Dominik Csapak
@ 2025-01-29 12:10 ` Dietmar Maurer
1 sibling, 0 replies; 3+ messages in thread
From: Dietmar Maurer @ 2025-01-29 12:10 UTC (permalink / raw)
To: Yew framework devel list at Proxmox, Dominik Csapak
applied both patches
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-29 12:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-29 9:41 [yew-devel] [PATCH yew-widget-toolkit 1/2] widget: menu button: actually use 'disabled' property Dominik Csapak
2025-01-29 9:42 ` [yew-devel] [PATCH yew-widget-toolkit 2/2] state: selection: make selection interface more consistent Dominik Csapak
2025-01-29 12:10 ` [yew-devel] applied: [PATCH yew-widget-toolkit 1/2] widget: menu button: actually use 'disabled' property Dietmar Maurer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox