[yew-devel] [PATCH yew-widget-toolkit] macros: fix build for tests

[yew-devel] [PATCH yew-widget-toolkit] macros: fix build for tests

[Shannon Sterz]

it seems adapting the test case in pwt-macros was forgotten at some
point. this makes the test cases build-able again. please note that
this does not make all test cases here work, as some of them seem to
expect the output of specific rustc versions. this should probably be
addressed in a separate commit.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 pwt-macros/tests/widget.rs | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/pwt-macros/tests/widget.rs b/pwt-macros/tests/widget.rs
index 82c2edcc..ee18f943 100644
--- a/pwt-macros/tests/widget.rs
+++ b/pwt-macros/tests/widget.rs
@@ -1,3 +1,5 @@
+
+#[allow(dead_code)]
 mod props {
     use yew::{virtual_dom::Key, Classes};
 
@@ -11,8 +13,20 @@ mod props {
     }
     pub trait CssPaddingBuilder {}
     pub trait CssMarginBuilder {}
+    pub trait AsCssStylesMut {
+        fn as_css_styles_mut(&mut self) -> &mut CssStyles;
+    }
+
+    /// Holds the CSS styles to set on elements
+    #[derive(Clone, Default, Debug, PartialEq)]
+    pub struct CssStyles {}
+
+    pub trait WidgetStyleBuilder {}
+
     pub trait WidgetBuilder: Sized {
         fn as_std_props_mut(&mut self) -> &mut WidgetStdProps;
+        fn as_std_props(&self) -> &WidgetStdProps;
+
         fn class(mut self, class: impl Into<Classes>) -> Self {
             self.add_class(class);
             self
@@ -30,6 +44,7 @@ mod props {
     pub struct WidgetStdProps {
         pub key: Option<Key>,
         pub class: Classes,
+        pub styles: CssStyles,
     }
     #[derive(PartialEq, Default, Clone)]
     pub struct ListenersWrapper {}
-- 
2.39.5



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel

[yew-devel] applied: [PATCH yew-widget-toolkit] macros: fix build for tests

[Dietmar Maurer]

applied


_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel

Re: [yew-devel] [PATCH yew-widget-toolkit] macros: fix build for tests

[Shannon Sterz]

On Mon Jan 13, 2025 at 3:27 PM CET, Shannon Sterz wrote:
> it seems adapting the test case in pwt-macros was forgotten at some
> point. this makes the test cases build-able again. please note that
> this does not make all test cases here work, as some of them seem to
> expect the output of specific rustc versions. this should probably be
> addressed in a separate commit.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  pwt-macros/tests/widget.rs | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/pwt-macros/tests/widget.rs b/pwt-macros/tests/widget.rs
> index 82c2edcc..fdbae602 100644
> --- a/pwt-macros/tests/widget.rs
> +++ b/pwt-macros/tests/widget.rs
> @@ -1,3 +1,5 @@
> +
> +    #[allow(dead_code)]

sorry i messed up the indentation here, will send a new patch in a
minute

>  mod props {
>      use yew::{virtual_dom::Key, Classes};
>
> @@ -11,8 +13,20 @@ mod props {
>      }
>      pub trait CssPaddingBuilder {}
>      pub trait CssMarginBuilder {}
> +    pub trait AsCssStylesMut {
> +        fn as_css_styles_mut(&mut self) -> &mut CssStyles;
> +    }
> +
> +    /// Holds the CSS styles to set on elements
> +    #[derive(Clone, Default, Debug, PartialEq)]
> +    pub struct CssStyles {}
> +
> +    pub trait WidgetStyleBuilder {}
> +
>      pub trait WidgetBuilder: Sized {
>          fn as_std_props_mut(&mut self) -> &mut WidgetStdProps;
> +        fn as_std_props(&self) -> &WidgetStdProps;
> +
>          fn class(mut self, class: impl Into<Classes>) -> Self {
>              self.add_class(class);
>              self
> @@ -30,6 +44,7 @@ mod props {
>      pub struct WidgetStdProps {
>          pub key: Option<Key>,
>          pub class: Classes,
> +        pub styles: CssStyles,
>      }
>      #[derive(PartialEq, Default, Clone)]
>      pub struct ListenersWrapper {}



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel

[yew-devel] [PATCH yew-widget-toolkit] macros: fix build for tests

[Shannon Sterz]

it seems adapting the test case in pwt-macros was forgotten at some
point. this makes the test cases build-able again. please note that
this does not make all test cases here work, as some of them seem to
expect the output of specific rustc versions. this should probably be
addressed in a separate commit.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 pwt-macros/tests/widget.rs | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/pwt-macros/tests/widget.rs b/pwt-macros/tests/widget.rs
index 82c2edcc..fdbae602 100644
--- a/pwt-macros/tests/widget.rs
+++ b/pwt-macros/tests/widget.rs
@@ -1,3 +1,5 @@
+
+    #[allow(dead_code)]
 mod props {
     use yew::{virtual_dom::Key, Classes};
 
@@ -11,8 +13,20 @@ mod props {
     }
     pub trait CssPaddingBuilder {}
     pub trait CssMarginBuilder {}
+    pub trait AsCssStylesMut {
+        fn as_css_styles_mut(&mut self) -> &mut CssStyles;
+    }
+
+    /// Holds the CSS styles to set on elements
+    #[derive(Clone, Default, Debug, PartialEq)]
+    pub struct CssStyles {}
+
+    pub trait WidgetStyleBuilder {}
+
     pub trait WidgetBuilder: Sized {
         fn as_std_props_mut(&mut self) -> &mut WidgetStdProps;
+        fn as_std_props(&self) -> &WidgetStdProps;
+
         fn class(mut self, class: impl Into<Classes>) -> Self {
             self.add_class(class);
             self
@@ -30,6 +44,7 @@ mod props {
     pub struct WidgetStdProps {
         pub key: Option<Key>,
         pub class: Classes,
+        pub styles: CssStyles,
     }
     #[derive(PartialEq, Default, Clone)]
     pub struct ListenersWrapper {}
-- 
2.39.5



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel