From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4AD071FF164 for ; Fri, 20 Dec 2024 11:32:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B1F4A2385; Fri, 20 Dec 2024 11:32:12 +0100 (CET) From: Dominik Csapak To: yew-devel@lists.proxmox.com Date: Fri, 20 Dec 2024 11:31:39 +0100 Message-Id: <20241220103139.1186480-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [dropdown.rs, self.show] Subject: [yew-devel] [PATCH yew-widget-toolkit v2] widget: dropdown: update picker placement after showing X-BeenThere: yew-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Yew framework devel list at Proxmox List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yew framework devel list at Proxmox Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: yew-devel-bounces@lists.proxmox.com Sender: "yew-devel" It seems that under certain circumstances (e.g. a dropdown in a dialog) updating the position of the picker before it's opened (it's a popover) does not work properly in safari/webkit/epiphany. When trying to open such a dropdown, it (or some parts of it) would be rendered with a height of 0px, even though the elements have a height set explicitly. To fix this, update the picker placement after opening it. What exactly is the cause (e.g. if it's a browser bug or our css/aligning) is yet to be determined. This fixes an issue on webkit (tested with epiphany) that opening dropdowns in a dialog did not show the dropdown properly. Signed-off-by: Dominik Csapak --- src/widget/dropdown.rs | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/widget/dropdown.rs b/src/widget/dropdown.rs index f9b49f1..a125bf6 100644 --- a/src/widget/dropdown.rs +++ b/src/widget/dropdown.rs @@ -510,12 +510,6 @@ impl Component for PwtDropdown { } } - if let Some(placer) = &self.picker_placer { - if let Err(err) = placer.update() { - log::error!("error updating placement: {}", err.to_string()); - } - } - if self.show != self.last_show { self.last_show = self.show; if let Some(popover_node) = self.picker_ref.get() { @@ -533,6 +527,14 @@ impl Component for PwtDropdown { } } } + + // update picker placement after we opened/closed it + if let Some(placer) = &self.picker_placer { + if let Err(err) = placer.update() { + log::error!("error updating placement: {}", err.to_string()); + } + } + self.focus_on_field = false; } } -- 2.39.5 _______________________________________________ yew-devel mailing list yew-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel