From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <yew-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 445A81FF18C
for <inbox@lore.proxmox.com>; Mon, 12 May 2025 10:31:23 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 934BE378D1;
Mon, 12 May 2025 10:31:44 +0200 (CEST)
Date: Mon, 12 May 2025 10:31:41 +0200 (CEST)
From: Dietmar Maurer <dietmar@proxmox.com>
To: Yew framework devel list at Proxmox <yew-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Message-ID: <1105368042.13622.1747038701538@webmail.proxmox.com>
In-Reply-To: <20250509071627.331064-1-d.csapak@proxmox.com>
References: <20250509071627.331064-1-d.csapak@proxmox.com>
MIME-Version: 1.0
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.6-Rev75
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.320 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [yew-devel] [PATCH yew-comp] fix #6382: tasks: don't add
duplicate tasks into the list
X-BeenThere: yew-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Yew framework devel list at Proxmox <yew-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/yew-devel>,
<mailto:yew-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/yew-devel/>
List-Post: <mailto:yew-devel@lists.proxmox.com>
List-Help: <mailto:yew-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel>,
<mailto:yew-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Yew framework devel list at Proxmox <yew-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: yew-devel-bounces@lists.proxmox.com
Sender: "yew-devel" <yew-devel-bounces@lists.proxmox.com>
>
> - let start = self.start;
> - filter["start"] = start.into();
> + let start = match (self.fresh_load, self.store.read().last()) {
> + (false, Some(last)) => last.starttime,
> + _ => 0,
> + };
> + if start > 0 && filter["until"].as_i64().unwrap_or(i64::MAX) > start {
> + filter["until"] = start.into();
> + }
The naming is quite confusing - maybe rename "start" into "until"?
Also, value "0" is not used (just a marker), so maybe it is cleaner to use an option?
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel