public inbox for yew-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [yew-devel] [PATCH proxmox-yew-comp 1/2] tasks: docs: Escape unscaped HTML
@ 2025-01-14  9:41 Maximiliano Sandoval
  2025-01-14  9:41 ` [yew-devel] [PATCH proxmox-yew-comp 2/2] wizzard: docs: Use full path for structs Maximiliano Sandoval
  2025-01-14 10:01 ` [yew-devel] applied: [PATCH proxmox-yew-comp 1/2] tasks: docs: Escape unscaped HTML Dietmar Maurer
  0 siblings, 2 replies; 3+ messages in thread
From: Maximiliano Sandoval @ 2025-01-14  9:41 UTC (permalink / raw)
  To: yew-devel

Fixes:

warning: unclosed HTML tag `nodename`
  --> src/tasks.rs:42:5
   |
42 |     /// The base url, default is '/nodes/<nodename>/tasks'
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(rustdoc::invalid_html_tags)]` on by default

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/tasks.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/tasks.rs b/src/tasks.rs
index 9a6ad63..4ea243f 100644
--- a/src/tasks.rs
+++ b/src/tasks.rs
@@ -39,7 +39,7 @@ pub struct Tasks {
     #[prop_or_default]
     pub extra_filter: Option<(AttrValue, Html)>,
 
-    /// The base url, default is '/nodes/<nodename>/tasks'
+    /// The base url, default is `/nodes/<nodename>/tasks`.
     #[prop_or_default]
     #[builder(IntoPropValue, into_prop_value)]
     pub base_url: Option<AttrValue>,
-- 
2.39.5



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [yew-devel] [PATCH proxmox-yew-comp 2/2] wizzard: docs: Use full path for structs
  2025-01-14  9:41 [yew-devel] [PATCH proxmox-yew-comp 1/2] tasks: docs: Escape unscaped HTML Maximiliano Sandoval
@ 2025-01-14  9:41 ` Maximiliano Sandoval
  2025-01-14 10:01 ` [yew-devel] applied: [PATCH proxmox-yew-comp 1/2] tasks: docs: Escape unscaped HTML Dietmar Maurer
  1 sibling, 0 replies; 3+ messages in thread
From: Maximiliano Sandoval @ 2025-01-14  9:41 UTC (permalink / raw)
  To: yew-devel

Fixes:

warning: unresolved link to `MiniScroll`
   --> src/wizard.rs:108:5
    |
108 |     /// Use [MiniScroll] for [TabBar] to allow scrolling.
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: the link appears in this line:

            Use [MiniScroll] for [TabBar] to allow scrolling.
                 ^^^^^^^^^^
    = note: no item named `MiniScroll` in scope
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
    = note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default

warning: unresolved link to `TabBar`
   --> src/wizard.rs:108:5
    |
108 |     /// Use [MiniScroll] for [TabBar] to allow scrolling.
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: the link appears in this line:

            Use [MiniScroll] for [TabBar] to allow scrolling.
                                  ^^^^^^
    = note: no item named `TabBar` in scope
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/wizard.rs | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/wizard.rs b/src/wizard.rs
index 44772ce..1ff7b6a 100644
--- a/src/wizard.rs
+++ b/src/wizard.rs
@@ -29,7 +29,7 @@ use super::{IntoSubmitValueCallback, SubmitValueCallback};
 
 use pwt_macros::builder;
 
-/// Infos passed to the [SelectionView] render function.
+/// Infos passed to the [pwt::widget::SelectionView] render function.
 #[derive(Clone, PartialEq)]
 pub struct WizardPageRenderInfo {
     /// The key of the item to render
@@ -105,7 +105,8 @@ pub struct Wizard {
     #[prop_or_default]
     pub html_title: Option<Html>,
 
-    /// Use [MiniScroll] for [TabBar] to allow scrolling.
+    /// Use [pwt::widget::MiniScroll] for [pwt::widget::TabBar] to allow
+    /// scrolling.
     #[prop_or_default]
     #[builder(IntoPropValue, into_prop_value)]
     pub scroll_mode: Option<MiniScrollMode>,
-- 
2.39.5



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [yew-devel] applied: [PATCH proxmox-yew-comp 1/2] tasks: docs: Escape unscaped HTML
  2025-01-14  9:41 [yew-devel] [PATCH proxmox-yew-comp 1/2] tasks: docs: Escape unscaped HTML Maximiliano Sandoval
  2025-01-14  9:41 ` [yew-devel] [PATCH proxmox-yew-comp 2/2] wizzard: docs: Use full path for structs Maximiliano Sandoval
@ 2025-01-14 10:01 ` Dietmar Maurer
  1 sibling, 0 replies; 3+ messages in thread
From: Dietmar Maurer @ 2025-01-14 10:01 UTC (permalink / raw)
  To: Yew framework devel list at Proxmox, Maximiliano Sandoval

applied both patches


_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-01-14 10:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-14  9:41 [yew-devel] [PATCH proxmox-yew-comp 1/2] tasks: docs: Escape unscaped HTML Maximiliano Sandoval
2025-01-14  9:41 ` [yew-devel] [PATCH proxmox-yew-comp 2/2] wizzard: docs: Use full path for structs Maximiliano Sandoval
2025-01-14 10:01 ` [yew-devel] applied: [PATCH proxmox-yew-comp 1/2] tasks: docs: Escape unscaped HTML Dietmar Maurer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal