[yew-devel] [PATCH yew-widget-toolkit v2] widget: dropdown: update picker placement after showing

[yew-devel] [PATCH yew-widget-toolkit v2] widget: dropdown: update picker placement after showing

[Dominik Csapak]

It seems that under certain circumstances (e.g. a dropdown in a dialog)
updating the position of the picker before it's opened (it's a
popover) does not work properly in safari/webkit/epiphany.

When trying to open such a dropdown, it (or some parts of it) would
be rendered with a height of 0px, even though the elements have
a height set explicitly.

To fix this, update the picker placement after opening it. What exactly
is the cause (e.g. if it's a browser bug or our css/aligning) is yet to
be determined.

This fixes an issue on webkit (tested with epiphany) that opening
dropdowns in a dialog did not show the dropdown properly.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/widget/dropdown.rs | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/widget/dropdown.rs b/src/widget/dropdown.rs
index f9b49f1..a125bf6 100644
--- a/src/widget/dropdown.rs
+++ b/src/widget/dropdown.rs
@@ -510,12 +510,6 @@ impl Component for PwtDropdown {
             }
         }
 
-        if let Some(placer) = &self.picker_placer {
-            if let Err(err) = placer.update() {
-                log::error!("error updating placement: {}", err.to_string());
-            }
-        }
-
         if self.show != self.last_show {
             self.last_show = self.show;
             if let Some(popover_node) = self.picker_ref.get() {
@@ -533,6 +527,14 @@ impl Component for PwtDropdown {
                 }
             }
         }
+
+        // update picker placement after we opened/closed it
+        if let Some(placer) = &self.picker_placer {
+            if let Err(err) = placer.update() {
+                log::error!("error updating placement: {}", err.to_string());
+            }
+        }
+
         self.focus_on_field = false;
     }
 }
-- 
2.39.5



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel

Re: [yew-devel] [PATCH yew-widget-toolkit v2] widget: dropdown: update picker placement after showing

[Dominik Csapak]

argh sry, forgot to add the changelog (a trivial one, but still), so here it is:

changes from v1:
* changed commit message to include more details
* add comment to moved code block to make the intent of the position clear


_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel

Re: [yew-devel] [PATCH yew-widget-toolkit v2] widget: dropdown: update picker placement after showing

[Maximiliano Sandoval]

This patch fixes the Theme selector dropdown not being visible in Epiphany 47.2.

Tested-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

Dominik Csapak <d.csapak@proxmox.com> writes:

> argh sry, forgot to add the changelog (a trivial one, but still), so here it is:
>
> changes from v1:
> * changed commit message to include more details
> * add comment to moved code block to make the intent of the position clear
>
>
> _______________________________________________
> yew-devel mailing list
> yew-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel

[yew-devel] applied: [PATCH yew-widget-toolkit v2] widget: dropdown: update picker placement after showing

[Thomas Lamprecht]

On 20/12/2024 11:31, Dominik Csapak wrote:
> It seems that under certain circumstances (e.g. a dropdown in a dialog)
> updating the position of the picker before it's opened (it's a
> popover) does not work properly in safari/webkit/epiphany.
> 
> When trying to open such a dropdown, it (or some parts of it) would
> be rendered with a height of 0px, even though the elements have
> a height set explicitly.
> 
> To fix this, update the picker placement after opening it. What exactly
> is the cause (e.g. if it's a browser bug or our css/aligning) is yet to
> be determined.
> 
> This fixes an issue on webkit (tested with epiphany) that opening
> dropdowns in a dialog did not show the dropdown properly.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/widget/dropdown.rs | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
>

applied, with Maximiliano's T-b and also the comment slightly extend for
why this is done, thanks!


_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel