public inbox for yew-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, yew-devel@lists.proxmox.com
Subject: applied: [PATCH yew-widget-toolkit v5 0/2] data table: auto width with sample store
Date: Tue, 20 Oct 2026 12:04:33 +0200	[thread overview]
Message-ID: <01f61616-0a49-4f4f-806e-d9c9e7a87be8@proxmox.com> (raw)
In-Reply-To: <20261019102103.1216720-1-d.csapak@proxmox.com>

applied

On 10/19/26 12:21 PM, Dominik Csapak wrote:
> implements auto sizing of columns with a sample store to render
> invisibly.
>
> changes from v4:
> * use a 'sample_store' instead of 'sample_records' (thanks @Dietmar),
>    so tree indentation is considered too
> * also apply the cell attributes to the sizers
> * also recalculate the sizers on selection/cell configuration changes
> * wrap the sizers in an Rc to avoid cloning/comparing them on every
>    render
> * only count filtered records for the debug assertion
> * document that sample store changes are not monitored
>
> changes from v3:
> * new patch: factor out the cell rendering loop of the table rows, so
>    it can be reused for the sample records (for colspan)
> * cache the rendered sizers and only recalculate them when the relevant
>    properties change, instead of on every render
> * move the debug assertion into the sizer calculation, so it also
>    covers property updates, and fix it to allow exactly
>    VIRTUAL_SCROLL_TRIGGER records
> * fix typos
> * improve comments
>
> Dominik Csapak (2):
>    widget: data table: factor out cell rendering logic
>    widget: data table: implement auto column sizing based on sample store
>
>   src/widget/data_table/data_table.rs    | 125 +++++++++++++++++++++++--
>   src/widget/data_table/header_widget.rs |  47 ++++++++++
>   src/widget/data_table/mod.rs           |   5 +-
>   src/widget/data_table/rendered_cell.rs |  63 +++++++++++++
>   src/widget/data_table/row.rs           |  66 +++++--------
>   5 files changed, 254 insertions(+), 52 deletions(-)
>   create mode 100644 src/widget/data_table/rendered_cell.rs
>




      parent reply	other threads:[~2026-10-20 10:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 10:19 [PATCH yew-widget-toolkit v5 0/2] data table: auto width with sample store Dominik Csapak
2026-10-19 10:19 ` [PATCH yew-widget-toolkit v5 1/2] widget: data table: factor out cell rendering logic Dominik Csapak
2026-10-19 10:19 ` [PATCH yew-widget-toolkit v5 2/2] widget: data table: implement auto column sizing based on sample store Dominik Csapak
2026-10-20 10:04 ` Dietmar Maurer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01f61616-0a49-4f4f-806e-d9c9e7a87be8@proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=yew-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal