From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3DD5972E06 for ; Sun, 4 Jul 2021 19:29:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2EE7618813 for ; Sun, 4 Jul 2021 19:29:31 +0200 (CEST) Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BF140187FC for ; Sun, 4 Jul 2021 19:29:28 +0200 (CEST) Received: by mail-wm1-x336.google.com with SMTP id w13so9809486wmc.3 for ; Sun, 04 Jul 2021 10:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=odiso-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:date:user-agent:mime-version; bh=FpxjGsGhj2T2ty8NKMTCEqwNNu9bDgpqegjOfLa6ofE=; b=KZ1mpCSrYXEPYO4lPPK2qXE3pPkYG7inaAPNWXNZzqymQI1RycRxCQENd9RuJePcTn RMT8/73QBsmDXUvAXyFxuUmP8DjHFgHrsRltzIQlCZho/27VGHxmb9vFUzmubKslizQQ of9OVvQFHmui4YstBP1FPP3JPibgE9MjO50r6gay/fvEte1vdeEiBF2ixEzXUXfrP7AT vhEAFrKNlFZgi3uJz715c3XfoUHHbTmIP43OB07xXwb2Fpk9vKqTf5c5mDpUMCCHDCjc zef8/ySOU4blg6ls71kqaElb23kEhKphvtt5avptmTnjVcIpTsV6V5kA4zZr/w4//dDm VLyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:user-agent :mime-version; bh=FpxjGsGhj2T2ty8NKMTCEqwNNu9bDgpqegjOfLa6ofE=; b=sLcxHp6N3ZRS8rLJk7cng/7Cd2knU0rzVk+BuwkHC9GGoQaaVhNutH/AfZ89/D2pEG si9smXuT2nhlhT3r7LNzABPi5O8zgW6bgneJLEQ0hhT5k5cSkjNdz/4/9VxRbRCyro5F qEBnrgXEjzsI1wapU2RxsCW19VjPpqwHhjr/jEOI4GTY5gwfNU5wat1Nr1aGsH7WYdCc q4lg5Eh+2XzRyW2ZjvfAXdIdQHw0plwcGGGo2cYEYDUMNL0aLkMxJHooJYzRjY1qy/zb sOT45rvfWZBq8hYchXhiFeqHWNWIS/C2SX3wKr6/M1N2bqy8/k31zh4A3duhVINqt6vx XfuQ== X-Gm-Message-State: AOAM532xjCqG0CTVHEn/Coe3uV5v4vWoJjZ0jIxp9btyX0+MKWjGqwpL F2676QWSDQumbvl56QO4YBrgcQ0GciMVgVWxo8k= X-Google-Smtp-Source: ABdhPJypI5y8Ru4H2c3qiF/+zfGVkDElcPbe850LBKF96EBhGB1ItnsDBsy1XP0tec5a/L4CElI23Q== X-Received: by 2002:a05:600c:1990:: with SMTP id t16mr3365133wmq.22.1625419762117; Sun, 04 Jul 2021 10:29:22 -0700 (PDT) Received: from ?IPv6:2a0a:1580:0:1::100c? (ovpn1.odiso.net. [2a0a:1580:2000::3f]) by smtp.gmail.com with ESMTPSA id o17sm19169374wmh.19.2021.07.04.10.29.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jul 2021 10:29:21 -0700 (PDT) Message-ID: From: alexandre derumier To: "pve-user@pve.proxmox.com" Date: Sun, 04 Jul 2021 19:29:20 +0200 User-Agent: Evolution 3.40.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.807 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature HTML_MESSAGE 0.001 HTML included in message RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [PVE-User] qemu-server: bug in vmconfig_apply_pending errors handling X-BeenThere: pve-user@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE user list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Jul 2021 17:29:31 -0000 Hi, I'm still working on ipam support for qemu-server, I have notice a bug in error handling of offline change apply, since commit https://git.proxmox.com/?p=qemu-server.git;a=commit;h=eb5e482ded9ae6aeb6575de9441b79b90a5de531 introduce $errors support API2/Qemu.pm -                PVE::QemuServer::vmconfig_apply_pending($vmid, $conf, $ storecfg, $running); +               PVE::QemuServer::vmconfig_apply_pending($vmid, $conf, $ storecfg, $running, $errors); PVE/QemuServer.pm  sub vmconfig_apply_pending { -    my ($vmid, $conf, $storecfg) = @_; +    my ($vmid, $conf, $storecfg, $errors) = @_; The problem is the $running param used,  not existing in the sub.