From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 1632193A8E
 for <pve-user@lists.proxmox.com>; Fri,  6 Jan 2023 11:15:05 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id F1AD4B135
 for <pve-user@lists.proxmox.com>; Fri,  6 Jan 2023 11:15:04 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-user@lists.proxmox.com>; Fri,  6 Jan 2023 11:15:03 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 250E944F66;
 Fri,  6 Jan 2023 11:15:03 +0100 (CET)
Message-ID: <7dc750d1-2bc3-be76-ab88-0838cb921b62@proxmox.com>
Date: Fri, 6 Jan 2023 11:15:02 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101
 Thunderbird/109.0
Content-Language: en-GB
To: Proxmox VE user list <pve-user@lists.proxmox.com>,
 Martin Dziobek <dziobek@hlrs.de>
References: <20230103133458.378a56b3@schleppmd.hlrs.de>
 <20230103144308.491d9e63@schleppmd.hlrs.de>
 <20230103150321.005ab826@schleppmd.hlrs.de>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20230103150321.005ab826@schleppmd.hlrs.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 1.432 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -2.939 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [PVE-User] Trouble with LetsEncrypt/acme-dns in pve 7.3-4 -
 FIXED
X-BeenThere: pve-user@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE user list <pve-user.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-user>, 
 <mailto:pve-user-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-user/>
List-Post: <mailto:pve-user@lists.proxmox.com>
List-Help: <mailto:pve-user-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-user>, 
 <mailto:pve-user-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 06 Jan 2023 10:15:05 -0000

Hi!

Am 03/01/2023 um 15:03 schrieb Martin Dziobek:
> Ok - here is the fix:

much thanks for your report and even proposing a fix, appreciated!

> 
> in /usr/share/proxmox-acme/dns-challenge-schema.json:
> 
> diff dns-challenge-schema.json dns-challenge-schema.json_save:

fyi, using the -u and -p param (can be combined as -up) makes the diff output more
like the git default, also putting original file first and the modified second is
more common and thus a bit easier to understand.

> 13,14c13,14
> <          "ACMEDNS_BASE_URL" : {
> <             "description" : "The API base url",
> ---
>>          "ACMEDNS_UPDATE_URL" : {
>>             "description" : "The API update endpoint",
> 
> Then restart pveproxy.
> Works.

Applied the change to git so that its fixed again with the next proxmox-acme package
version bump:

https://git.proxmox.com/?p=proxmox-acme.git;a=commitdiff;h=963319d031d43bbdc5dd78414852989eb9e9e40f

- Thomas