From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 79D4F1FF13F
	for <inbox@lore.proxmox.com>; Thu, 12 Mar 2026 11:50:17 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id D9B8210CED;
	Thu, 12 Mar 2026 11:50:11 +0100 (CET)
Date: Thu, 12 Mar 2026 11:49:36 +0100
From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-manager] fix #7337: Keep track of deep link on OpenID
 login
Message-ID: <zmuybnjepyjj4ic2aqubpxytnynsy2nwl4j3v7cmto6cb5e64r@c23c7bbom6xj>
References: <20260312101227.212668-1-a.bied-charreton@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260312101227.212668-1-a.bied-charreton@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1773312542096
X-SPAM-LEVEL: Spam detection results:  0
	AWL                    -0.265 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	RCVD_IN_MSPIKE_H2       0.001 Average reputation (+2)
	RCVD_IN_VALIDITY_CERTIFIED_BLOCKED  0.408 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_RPBL_BLOCKED  0.819 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_SAFE_BLOCKED  0.903 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: 4ANKC6LQM75CM35LYRVZ7J5ERK6ITRQT
X-Message-ID-Hash: 4ANKC6LQM75CM35LYRVZ7J5ERK6ITRQT
X-MailFrom: a.bied-charreton@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Thu, Mar 12, 2026 at 11:12:27AM +0100, Arthur Bied-Charreton wrote:
> Previously, when opening a deep link without being logged into PVE, the
> hash was getting lost, redirecting the user to / instead of
> /#<deeplink>.
> 
> Store `window.location.hash` in sessionStorage (per-tab storage) before
> redirecting to the login URL, and add it to `Ext.History` after successful
> login to direct the user to the deeplink they opened.
> 
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> 
[...]

Quick side note that this is also an issue in PBS, will send a follow-up
patch to the pbs list once we validate this approach/agree on another one
here.