From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 28EA790881 for ; Mon, 12 Feb 2024 11:15:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1274C16769 for ; Mon, 12 Feb 2024 11:15:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 12 Feb 2024 11:15:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2087D47889 for ; Mon, 12 Feb 2024 11:15:54 +0100 (CET) Date: Mon, 12 Feb 2024 11:15:53 +0100 From: Christoph Heiss To: Aaron Lauterer Cc: Proxmox VE development discussion Message-ID: References: <20240209105629.285910-1-c.heiss@proxmox.com> <20240209105629.285910-2-c.heiss@proxmox.com> <2c2261b3-380e-4c0f-8077-bff387caaf9d@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2c2261b3-380e-4c0f-8077-bff387caaf9d@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH installer 1/4] low-level: initialize UI backend for 'dump-env' subcommand too X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2024 10:15:55 -0000 On Fri, Feb 09, 2024 at 01:36:12PM +0100, Aaron Lauterer wrote: > Is this something I should consider for the new dump-udev subcommand as well? > > https://lists.proxmox.com/pipermail/pve-devel/2024-January/061433.html As it also calls deeper into the installer code, I'd say yes. Although nothing ever calls UI code on that chain, better future-proof it now :^) > > On 2/9/24 11:55, Christoph Heiss wrote: > > Some detection routines might try to log things and call some > > Proxmox::Ui functions all the way down, so just initialize it with the > > stdio backend to avoid errors. > > > > Signed-off-by: Christoph Heiss > > --- > > proxmox-low-level-installer | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/proxmox-low-level-installer b/proxmox-low-level-installer > > index d127a40..2848295 100755 > > --- a/proxmox-low-level-installer > > +++ b/proxmox-low-level-installer > > @@ -91,6 +91,7 @@ Proxmox::Log::init("/tmp/install-low-level-${cmd}.log"); > > my $env = Proxmox::Install::ISOEnv::get(); > > if ($cmd eq 'dump-env') { > > + Proxmox::UI::init_stdio({}, $env); > > my $out_dir = $env->{locations}->{run}; > > make_path($out_dir);