From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 688EF1FF16E
for <inbox@lore.proxmox.com>; Mon, 31 Mar 2025 17:05:14 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id D89579845;
Mon, 31 Mar 2025 17:05:02 +0200 (CEST)
Date: Mon, 31 Mar 2025 17:04:59 +0200
From: Gabriel Goller <g.goller@proxmox.com>
To: Christoph Heiss <c.heiss@proxmox.com>
Message-ID: <yrhrdjiceiodo3mddwh3aorehhvzumzv25rgj6ta4rcq2vssjw@ntkezqh42qat>
Mail-Followup-To: Christoph Heiss <c.heiss@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20250328171340.885413-1-g.goller@proxmox.com>
<20250328171340.885413-14-g.goller@proxmox.com>
<D8UHYYYC0U61.3N7QU0UXZHKPW@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <D8UHYYYC0U61.3N7QU0UXZHKPW@proxmox.com>
User-Agent: NeoMutt/20241002-35-39f9a6
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.024 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH proxmox-ve-rs 12/17] ve-config: add
openfabric section-config
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On 31.03.2025 15:48, Christoph Heiss wrote:
>On Fri Mar 28, 2025 at 6:13 PM CET, Gabriel Goller wrote:
>> This is the main openfabric configuration. It is used to parse from the
>> section-config file (`/etc/pve/sdn/fabrics/openfabric.cfg`) and is also
>> returned from the api.
>>
>> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
>> ---
>> proxmox-ve-config/Cargo.toml | 9 +-
>> .../src/sdn/fabric/openfabric/mod.rs | 291 ++++++++++++++++++
>> 2 files changed, 297 insertions(+), 3 deletions(-)
>> create mode 100644 proxmox-ve-config/src/sdn/fabric/openfabric/mod.rs
>>
>> diff --git a/proxmox-ve-config/Cargo.toml b/proxmox-ve-config/Cargo.toml
>> index 4906d77550f3..3f7639efa153 100644
>> --- a/proxmox-ve-config/Cargo.toml
>> +++ b/proxmox-ve-config/Cargo.toml
>> @@ -10,14 +10,17 @@ exclude.workspace = true
>> log = "0.4"
>> anyhow = "1"
>> nix = "0.26"
>> -thiserror = "1.0.59"
>> +thiserror = { workspace = true }
>>
>> -serde = { version = "1", features = [ "derive" ] }
>> +serde = { workspace = true, features = [ "derive" ] }
>> +serde_with = { workspace = true }
>> serde_json = "1"
>> serde_plain = "1"
>> -serde_with = "3"
>> +tracing = "0.1"
>>
>> proxmox-schema = "4"
>> +proxmox-section-config = { workspace = true }
>> +proxmox-serde = { version = "0.1.2" }
>> proxmox-sys = "0.6.4"
>> proxmox-sortable-macro = "0.1.3"
>> proxmox-network-types = { version = "0.1", path = "../proxmox-network-types/" }
>
>nit: These changes should be reflected in debian/control too.
>
>Its sync'd up later in patch #16 ("ve-config: add section-config to frr
>types conversion") as part of another change in Cargo.toml, but they
>should always be grouped together, IMO.
Oops, yeah, will fix this.
Also messed up the similar-asserts import and debian/control entry as in
your other reply.
Also changed from similar-asserts to insta, so this shouldn't be an
issue in the next version!
Thanks for reviewing!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel