From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EBFDF9D83D for ; Fri, 27 Oct 2023 10:29:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CA06C369D1 for ; Fri, 27 Oct 2023 10:29:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 27 Oct 2023 10:29:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E2955423F3; Fri, 27 Oct 2023 10:29:26 +0200 (CEST) Date: Fri, 27 Oct 2023 10:29:26 +0200 From: Christoph Heiss To: Thomas Lamprecht Cc: Gilberto Ferreira , Proxmox VE development discussion Message-ID: References: <20231024115530.1101733-1-c.heiss@proxmox.com> <20231024115530.1101733-2-c.heiss@proxmox.com> <7l5h7ecjzznfpagtvnk7xcp7s2cu7njnnext2dp4zcwgyxbk3p@r5nlqvepijry> <97055168-3ed7-4338-8890-05bbe8c893ee@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <97055168-3ed7-4338-8890-05bbe8c893ee@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add new ZFS `arc_max` setup option X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2023 08:29:58 -0000 On Wed, Oct 25, 2023 at 07:09:00PM +0200, Thomas Lamprecht wrote: > > Am 25/10/2023 um 10:28 schrieb Christoph Heiss: > > On Tue, Oct 24, 2023 at 08:59:36AM -0300, Gilberto Ferreira via pve-devel wrote: > > > > Currently, this isn't planned, although - since that setting is exposed > > after all in the installer in the future - it would be kind of sensible > > to add it to the GUI as well, I guess. > > But as a separate series from this one, of course. > > > > CC @Thomas - what do you think? > > We would need to either have a separate config entry, that can easily > get out of sync with the actual configured values, or parse all possible > ways to set this, e.g., modprobe configs, which isn't too nice. Yeah, that actually seems like a big problem. > > With a few trade-offs/limitations one could probably work around that, > but IMO it can be a bit too much hassle for something that one normally > changes only once or twice (or once this change is in, probably never > for new setups), so for now I'd keep this manual. Then I'd also leave it at this, just being able to change it in the installer and afterwards only "manually". It is more than sufficiently documented in our guides how to change that, let alone searching for that topic on the internet. Thanks for chiming in!