From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id ADA601FF15C for ; Fri, 11 Jul 2025 10:32:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9A714B52A; Fri, 11 Jul 2025 10:33:17 +0200 (CEST) Date: Fri, 11 Jul 2025 10:33:14 +0200 From: Gabriel Goller To: Wolfgang Bumiller Message-ID: Mail-Followup-To: Wolfgang Bumiller , pve-devel@lists.proxmox.com References: <20250702145101.894299-1-g.goller@proxmox.com> <20250702145101.894299-23-g.goller@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20241002-35-39f9a6 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.013 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-ve-rs v4 16/22] config: sdn: fabrics: add section config X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: pve-devel@lists.proxmox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" >> [snip] >> diff --git a/proxmox-ve-config/src/sdn/fabric/section_config/mod.rs b/proxmox-ve-config/src/sdn/fabric/section_config/mod.rs >> index 7db378837eb1..174ea4d126c5 100644 >> --- a/proxmox-ve-config/src/sdn/fabric/section_config/mod.rs >> +++ b/proxmox-ve-config/src/sdn/fabric/section_config/mod.rs >> @@ -2,3 +2,108 @@ pub mod fabric; >> pub mod interface; >> pub mod node; >> pub mod protocol; >> + >> +use const_format::concatcp; >> +use serde::{Deserialize, Serialize}; >> + >> +use crate::sdn::fabric::section_config::{ >> + fabric::{Fabric, FabricSection, FABRIC_ID_REGEX_STR}, >> + node::{Node, NodeSection, NODE_ID_REGEX_STR}, >> + protocol::{ >> + openfabric::{OpenfabricNodeProperties, OpenfabricProperties}, >> + ospf::{OspfNodeProperties, OspfProperties}, >> + }, >> +}; >> + >> +use proxmox_schema::{api, const_regex, ApiStringFormat}; >> + >> +/// Represents a value that can be one of two given types. >> +/// >> +/// This is used for the fabrics section config, where values could either be Fabrics or Nodes. It > >Then please make it `Fabric(F)` and `Node(N)` instead of `Left` and >`Right`... > >A local helper type with a completely generic name and variant names is >just confusing otherwise. Agree, changed it. >> +/// can be used to split the sections contained in the config into their concrete types safely. >> +pub enum Either { >> + Left(L), >> + Right(R), >> +} >> + >> +impl From
for Either { >> + fn from(section: Section) -> Self { >> + match section { >> + Section::OpenfabricFabric(fabric_section) => Self::Left(fabric_section.into()), >> + Section::OspfFabric(fabric_section) => Self::Left(fabric_section.into()), >> + Section::OpenfabricNode(node_section) => Self::Right(node_section.into()), >> + Section::OspfNode(node_section) => Self::Right(node_section.into()), >> + } >> + } >> +} >> + >> [snip] Thanks! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel