From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 4BC771FF0B4 for ; Tue, 10 Nov 2026 15:35:45 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5856F21614; Tue, 10 Nov 2026 15:35:42 +0100 (CET) Date: Tue, 10 Nov 2026 15:35:37 +0100 From: Wolfgang Bumiller To: "Max R. Carrara" Subject: Re: [PATCH pve-storage v4 02/17] api: plugins/storage: add initial routes and endpoints Message-ID: References: <20261106154554.2182986-1-m.carrara@proxmox.com> <20261106154554.2182986-3-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261106154554.2182986-3-m.carrara@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794321337621 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.354 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FID34BRRUANK6LRCBO6WWZLFADAHJB7T X-Message-ID-Hash: FID34BRRUANK6LRCBO6WWZLFADAHJB7T X-MailFrom: w.bumiller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com, Alfonso Kuen , Thomas Ellmenreich , Jakob Klocker X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, Nov 06, 2026 at 04:45:38PM +0100, Max R. Carrara wrote: > Add the following routes / endpoints: > > * `GET plugins/storage` > Directory index, listing the direct child path components (so, > just 'plugin' currently). > > * `GET plugins/storage/plugin` > Lists all installed storage plugins and their metadata. > Currently, this is just an array of objects, with each object > containing the plugin's `type()` and Perl module path. Exposing perl module paths over the API is not a great idea. Consider what this would look like when we add/move over to rust or other plugin types. API-wise we should only care about the type I think. UI/UX wise, plugins could get a "display name", version (plugin side, not checked by us at all), author, license fields plugins could fill if they want to, alongside a non-overideable "built-in" flag sent by the API? > > * `GET plugins/storage/plugin/{type}` > Returns the metadata for a single plugin given by `{type}`. > > Signed-off-by: Max R. Carrara > --- > src/PVE/API2/Makefile | 1 + > src/PVE/API2/Plugins/Makefile | 18 +++++ > src/PVE/API2/Plugins/Storage.pm | 52 ++++++++++++ > src/PVE/API2/Plugins/Storage/Makefile | 17 ++++ > src/PVE/API2/Plugins/Storage/Plugin.pm | 106 +++++++++++++++++++++++++ > 5 files changed, 194 insertions(+) > create mode 100644 src/PVE/API2/Plugins/Makefile > create mode 100644 src/PVE/API2/Plugins/Storage.pm > create mode 100644 src/PVE/API2/Plugins/Storage/Makefile > create mode 100644 src/PVE/API2/Plugins/Storage/Plugin.pm > 8< snip >8