From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 9853E1FF15E
	for <inbox@lore.proxmox.com>; Wed, 21 Jan 2026 11:38:04 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 6DBF4222AC;
	Wed, 21 Jan 2026 11:38:20 +0100 (CET)
Date: Wed, 21 Jan 2026 11:37:45 +0100
From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Message-ID: <xsdxyqhsinxqkfooqduor7n53hcorcbtac6uemjzrx7n5bameb@uxzl2slbzesd>
References: <20260121101949.175620-1-a.bied-charreton@proxmox.com>
 <20260121101949.175620-3-a.bied-charreton@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20260121101949.175620-3-a.bied-charreton@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1768991810602
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.964 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH pve-storage] fix #7077: Improve error
 message for IDS shorter than 2 characters
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On Wed, Jan 21, 2026 at 11:15:08AM +0100, Arthur Bied-Charreton wrote:
> The regex in Storage::parse_lvm_name requires at least 2 characters, but
> shorter IDs only failed with "contains illegal characters". Add explicit
> length check to return a clearer error message in this case.
> 
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> ---
>  src/PVE/Storage/Plugin.pm | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
> index 6f3d691..58f714c 100644
> --- a/src/PVE/Storage/Plugin.pm
> +++ b/src/PVE/Storage/Plugin.pm
> @@ -333,6 +333,11 @@ PVE::JSONSchema::register_format('pve-storage-vgname', \&parse_lvm_name);
>  sub parse_lvm_name {
>      my ($name, $noerr) = @_;
>  
> +    if (length($name) < 2) {
> +        return undef if $noerr;
> +        die "lvm name '$name' can't be shorter than 2 characters\n";
> +    }
> +
>      if ($name !~ m/^[a-z0-9][a-z0-9\-\_\.]*[a-z0-9]$/i) {
>          return undef if $noerr;
>          die "lvm name '$name' contains illegal characters\n";
> -- 
> 2.47.3
> 
> 
This was supposed to be sent as part of a series, sorry about that,
please disregard and refer to:
https://lore.proxmox.com/pve-devel/20260121103407.187187-1-a.bied-charreton@proxmox.com/T/#t


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel