From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8EEA21FF140 for ; Fri, 24 Apr 2026 10:46:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4A0D910118; Fri, 24 Apr 2026 10:46:45 +0200 (CEST) Date: Fri, 24 Apr 2026 10:46:09 +0200 From: Arthur Bied-Charreton To: Shannon Sterz Subject: Re: [PATCH proxmox-backup v4 23/24] notifications: Add OAuth2 section to SMTP target docs Message-ID: References: <20260421115957.402589-1-a.bied-charreton@proxmox.com> <20260421115957.402589-24-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777020280843 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.770 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VVUHG25QNLQHUKKLIJOD43NSR2OU3BME X-Message-ID-Hash: VVUHG25QNLQHUKKLIJOD43NSR2OU3BME X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, Apr 24, 2026 at 10:18:38AM +0200, Shannon Sterz wrote: > On Fri Apr 24, 2026 at 9:59 AM CEST, Arthur Bied-Charreton wrote: > > On Thu, Apr 23, 2026 at 02:24:30PM +0200, Shannon Sterz wrote: > >> On Tue Apr 21, 2026 at 1:59 PM CEST, Arthur Bied-Charreton wrote: > > -->8 snip 8<-- > > >> > +Google > >> > +'''''' > >> > + > >> > +Google does not allow bare IP addresses as redirect URIs. To work around this, > >> > +add an entry to ``/etc/hosts`` **on the machine where your browser is > >> > +running**, i.e., your local workstation. > >> > + > >> > +:: > >> > + > >> > + # Replace with the IP address of your Proxmox Backup Server node > >> > + local.oauth2-redirect.com > >> > + > >> > >> not sure if that makes sense here. what if the device a user is using > >> doesn't allow changing the hosts file (e.g. insufficient permissions or > >> they are using a locked down phone etc.)? > >> > >> if we do add this section, consider using a reserved second level domain > >> instead [1]. using a domain that could be be registered and misused > >> seems dangerous to me. > >> > >> [1]: https://datatracker.ietf.org/doc/html/rfc2606#section-3 > >> > > Thanks for the feedback! I am actually unsure if this hack even belongs > > in our docs now that I think about it again. Maybe it would suffice to > > just add a warning stating that Google does not allow bare IP addresses > > and let users figure out how they want to work around that, or even > > remove it altogether - what do you think? It is not really related to > > PBS itself after all. > > > > yes adding a warning that bare ips aren't accepted and dropping the > work-around section seems reasonable to me. we tend to target an > audience that can probably figure out a work around if needed. so it > shouldn't be to hard to come up with a way to make address resolution > work on their end. > > if you want to keep a hint at the host file around you could do > something like this imo: > > .. NOTE:: Google does not allow IP addresses as redirect URIs. If you > need to work around this, specify a dummy domain as the redirect URI > and make sure that your local machine resolves it to the proper IP > address (by, for example, adding a line to ``/etc/hosts``). > > and leave it at that, most of our users should hopefully be able to > figure out how to make this work for them. > > -->8 snip 8<-- Sounds good, will do that - thank you for the review!