From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 78F9D1FF38E for ; Mon, 13 May 2024 11:51:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B58CD126EB; Mon, 13 May 2024 11:51:12 +0200 (CEST) Date: Mon, 13 May 2024 11:50:36 +0200 From: Christoph Heiss To: Aaron Lauterer Message-ID: References: <20240507132220.1218652-1-c.heiss@proxmox.com> <9adff507-fda2-494d-bf79-307a7c668428@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9adff507-fda2-494d-bf79-307a7c668428@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH installer 0/4] assistant: clean up glob patterns & regexes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Mon, May 13, 2024 at 11:18:51AM +0200, Aaron Lauterer wrote: > it seems these patches don't apply anymore. could you please do a rebase on > current master? Sure, thanks for the notice! Seems 1a01a01 ("assistant: keep prepared iso bootable on uefi with flash drives") "broke" it, due to an import statement change :') v2: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063833.html > > On 2024-05-07 15:21, Christoph Heiss wrote: > > The proxmox-auto-install-assistant uses > > - glob patterns for disk matching, which can be pre-compiled for > > efficiency > > - regexes for udev property matching, which can be simplified by some > > simple prefix matching & splitting on = > > > > The latter also significantly reduces binary size due to the removing > > the regex dependency, for details see patch #4. > > > > Overall no functional changes in this series. > > > > Christoph Heiss (4): > > tree-wide: run rustfmt, fix clippy warnings > > assistant: drop unused `log` dependency > > assistant: pre-compile ignored block device patterns > > assistant: avoid regex for simple prefix matching > > > > proxmox-auto-install-assistant/Cargo.toml | 2 - > > proxmox-auto-install-assistant/src/main.rs | 75 ++++++++----------- > > proxmox-auto-installer/tests/parse-answer.rs | 14 ++-- > > .../src/fetch_plugins/partition.rs | 10 +-- > > 4 files changed, 45 insertions(+), 56 deletions(-) > > > > -- > > 2.44.0 > > > > > > > > _______________________________________________ > > pve-devel mailing list > > pve-devel@lists.proxmox.com > > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel