From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D3E8996245 for ; Thu, 29 Feb 2024 10:05:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B8FE618869 for ; Thu, 29 Feb 2024 10:05:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 29 Feb 2024 10:05:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4FC8047F23 for ; Thu, 29 Feb 2024 10:05:13 +0100 (CET) Date: Thu, 29 Feb 2024 10:05:12 +0100 From: Christoph Heiss To: Stoiko Ivanov Cc: Proxmox VE development discussion Message-ID: References: <20240228180828.1412762-1-c.heiss@proxmox.com> <20240228200308.4a2f8c35@rosa.proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240228200308.4a2f8c35@rosa.proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] applied: [PATCH pmg-docs] installation: fix codeblock rendering in zfs performance tips section X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Feb 2024 09:05:17 -0000 On Wed, Feb 28, 2024 at 08:03:08PM +0100, Stoiko Ivanov wrote: > Thanks for the catch and fix! applied it! Thanks! > > (nit: pmg-devel@list.proxmox.com is preferred for pmg-docs patches) Saw it unfortunately only when it was already to late - sorry for the noise! > > On Wed, 28 Feb 2024 19:08:21 +0100 > Christoph Heiss wrote: > > > That slipped through, asciidoc uses 4 not 3 dashes for that. > > > > Fixes: c8be3f0 ("installation: align zfs performance tip with PVE documentation") > > Signed-off-by: Christoph Heiss > > --- > > pmg-installation.adoc | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/pmg-installation.adoc b/pmg-installation.adoc > > index 326fe5b..25d16a7 100644 > > --- a/pmg-installation.adoc > > +++ b/pmg-installation.adoc > > @@ -284,9 +284,9 @@ ZFS can use a dedicated drive as write cache, called the ZFS Intent Log (ZIL). > > Use a fast drive (SSD) for it. It can be added after installation with the > > following command: > > > > ---- > > +---- > > # zpool add log > > ---- > > +---- > > > > Adding the `nomodeset` Kernel Parameter > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >