From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8DF0A1FF140 for ; Fri, 27 Mar 2026 08:49:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 17E8F34F4F; Fri, 27 Mar 2026 08:49:27 +0100 (CET) Date: Fri, 27 Mar 2026 08:48:48 +0100 From: Arthur Bied-Charreton To: Maximiliano Sandoval Subject: Re: [PATCH pve-manager 5/8] ui: Add CPU flag editor for custom models Message-ID: References: <20260312084021.124465-1-a.bied-charreton@proxmox.com> <20260312084021.124465-6-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774597680262 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.795 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CVEDMDKHANTQOFZNPAXUQDILB3YGDJT6 X-Message-ID-Hash: CVEDMDKHANTQOFZNPAXUQDILB3YGDJT6 X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Mar 26, 2026 at 04:40:12PM +0100, Maximiliano Sandoval wrote: > Arthur Bied-Charreton writes: > [...] > > { > > + text: gettext('Set'), > > This would benefit from a TRANSLATORS comment. Is this a noun (set as in > set theory)? is it a verb (to set)? From the point of view of > translators there is not enough context to decide. > It is 'to set' (German 'setzen'), but on second thought it does not feel right to describe a value with a verb like this, maybe something like 'Value' would be better. Thanks for the feedback! [...] > > + 'A custom CPU model using acceleration-specific flags should only be assigned to VMs configured with the matching acceleration type, i.e., `kvm: off` for TCG, or `kvm: on` for KVM.', > > I would recommend to use quotes `"`, single-quotes `'` in user-facing > strings. Backticks are a markup/markdown concept. See [1]. > > off-topic: In principle one should use “” rather than "", but I don't > think there is precedent for this the codebase. > > [1] https://en.wikipedia.org/wiki/Quotation_mark#In_English > You're right, those look weird when not rendered. Will change that in v2, thanks! > [...] > -- > Maximiliano