From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 983E49EECC for ; Wed, 7 Jun 2023 14:23:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7A08619AA2 for ; Wed, 7 Jun 2023 14:23:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 7 Jun 2023 14:23:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CD6EE41EF6 for ; Wed, 7 Jun 2023 14:23:37 +0200 (CEST) Date: Wed, 7 Jun 2023 14:23:36 +0200 From: Wolfgang Bumiller To: Thomas Lamprecht Cc: Proxmox VE development discussion Message-ID: References: <20230606130851.260129-1-d.csapak@proxmox.com> <20230606130851.260129-5-d.csapak@proxmox.com> <27f9be2e-dd66-98c4-f873-e7643e046c9a@proxmox.com> <7e8b643e-f04e-1ed9-673a-41ba0073a129@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.127 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] applied: [PATCH http-server v3 1/2] proxy request: forward json content type and parameters X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2023 12:23:38 -0000 On Wed, Jun 07, 2023 at 02:14:37PM +0200, Thomas Lamprecht wrote: > Am 07/06/2023 um 14:08 schrieb Wolfgang Bumiller: > > On Wed, Jun 07, 2023 at 01:59:26PM +0200, Thomas Lamprecht wrote: > >> Am 07/06/2023 um 13:49 schrieb Dominik Csapak: > >>> > >>> > >>> On 6/7/23 13:47, Thomas Lamprecht wrote: > >>>> Am 07/06/2023 um 13:23 schrieb Wolfgang Bumiller: > >>>>> applied both & bumped dependency for pve-common > >>>>> > >>>> > >>>> Isn't this breaking older common too? > >>>> > >>> > >>> no it just forwards the parameters to either the daemon or the other nodes as json if the proxy received it as json, should not have > >>> any other effects... > >> > >> not this one 2/2, just replied here as it was the applied patch > > > > Meh, I suppose technically it does, but requires a... broken(?) client > > to trigger it, since no API endpoints with arrays which reach this case > > existed before? > > > > But Dominik writes in a reply to 2/2: > > > > > this patch breaks pve-common without the common 1/3 applied > > since the gui sends arrays when the api expects a '-list' > > and the api treats '-list' and '-alist' the same > > I.e., this breaks manager, and the workaround for that is in common, so either > http-server breaks older manager (i.e., the version before increasing the > versioned dependency for libpve-common-perl >= the one containing 1/3 in manager. > > Alternatively this could break older libpve-common-perl, enforcing that manager > always gets a workable set of packages for it's state. Right, I'll add a breaks entry for common.