From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 6E84E1FF0DF for ; Thu, 15 Oct 2026 07:46:57 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 591D6213BC; Thu, 15 Oct 2026 07:46:53 +0200 (CEST) Date: Thu, 15 Oct 2026 07:46:46 +0200 From: Arthur Bied-Charreton To: Stefan Hanreich Subject: superseded: [PATCH pve-firewall v2] api: aliases: make 'cidr' optional when updating Message-ID: References: <20260929132534.479718-1-a.bied-charreton@proxmox.com> <179199180896.318505.14249674297284436098.b4-review@b4> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <179199180896.318505.14249674297284436098.b4-review@b4> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792043207347 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.958 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3JW6HBYBEIVRXCGGOBTC3E7TM2DLRQOT X-Message-ID-Hash: 3JW6HBYBEIVRXCGGOBTC3E7TM2DLRQOT X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Oct 14, 2026 at 05:30:08PM +0200, Stefan Hanreich wrote: > > @@ -251,7 +251,10 @@ sub register_update_alias { > > > > raise_param_exc({ name => "no such alias" }) if !$aliases->{$name}; > > > > - my $data = { name => $param->{name}, cidr => $param->{cidr} }; > > + my $data = { > > + name => $param->{name}, > > + cidr => $param->{cidr} // $aliases->{$name}->{cidr}, > > + }; > > $data->{comment} = $param->{comment} if $param->{comment}; > > The comment here gets overwritten when updating the cidr, also when > renaming. > true, thanks for noticing that! superseded by: https://lore.proxmox.com/pve-devel/20261015054534.25978-1-a.bied-charreton@proxmox.com/T/#u > -- > Stefan Hanreich