From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id CDAF61FF13F for ; Thu, 12 Mar 2026 10:35:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4455DC290; Thu, 12 Mar 2026 10:35:22 +0100 (CET) Date: Thu, 12 Mar 2026 10:35:17 +0100 From: Gabriel Goller To: Hannes Laimer Subject: Re: [PATCH proxmox-ve-rs v5 8/8] frr: add bgp support with templates and serialization Message-ID: Mail-Followup-To: Hannes Laimer , pve-devel@lists.proxmox.com References: <20260310120705.150425-1-g.goller@proxmox.com> <20260310120705.150425-9-g.goller@proxmox.com> <3eaa05d4-e305-4f54-b1c1-2f5e7bd2adcc@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3eaa05d4-e305-4f54-b1c1-2f5e7bd2adcc@proxmox.com> User-Agent: NeoMutt/20241002-35-39f9a6 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773308082280 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NJ4ML2ZKFYDV5CT6SWGGPIJAN3Y3XBGA X-Message-ID-Hash: NJ4ML2ZKFYDV5CT6SWGGPIJAN3Y3XBGA X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 12.03.2026 09:30, Hannes Laimer wrote: > On 2026-03-10 13:08, Gabriel Goller wrote: > > Implements bgp routing configuration (rust types and templates) > > including routers, neighbor groups, address families (IPv4/IPv6 unicast, > > L2VPN EVPN), VRFs, route redistribution, and prefix lists. > > > > Co-authored-by: Stefan Hanreich > > Signed-off-by: Gabriel Goller > > --- > > [..] > > > diff --git a/proxmox-frr-templates/templates/bgpd.jinja b/proxmox-frr-templates/templates/bgpd.jinja > > new file mode 100644 > > index 000000000000..cdd0a50abf8c > > --- /dev/null > > +++ b/proxmox-frr-templates/templates/bgpd.jinja > > @@ -0,0 +1,35 @@ > > +{% from "bgp_router.jinja" import bgp_router %} > > +{% for vrf_name, vrf in bgp.vrfs|items %} > > +! > > +vrf {{ vrf_name }} > > +{% if vrf.vni %} > ^ > > + vni {{ vrf.vni }} > > I don't we do that currently, but it is possible to have routes in a VRF > but no VNI, shouldn't be a problem for us, just wanted to note it Yep, also just noticed this when pulling out the templates for the VRF stuff! Thanks for the review! > > +{% for ip_route in vrf.ip_routes %} > > +{% if ip_route.vrf %} > > + {{ "ipv6" if ip_route.is_ipv6 else "ip" }} route {{ ip_route.prefix }} {{ ip_route.via }} {{ ip_route.vrf }} > > +{% else %} > > + {{ "ipv6" if ip_route.is_ipv6 else "ip" }} route {{ ip_route.prefix }} {{ ip_route.via }} > > +{% endif %} > > +{% endfor %} > > +{% endif %} > ^ > > +{% for line in vrf.custom_frr_config %} > > +{{ line }} > > +{% endfor %} > > +exit-vrf > > +{% endfor %} > > +{% for vrf_name, router_config in bgp.vrf_router|items %} > > +! > > +{% if vrf_name == "default" %} > > +router bgp {{ router_config.asn }} > > +{% else %} > > +router bgp {{ router_config.asn }} vrf {{ vrf_name }} > > +{% endif %} > > +{{ bgp_router(router_config) -}} > > +exit > > +{% endfor %} > > +{% for view_id, router_config in bgp.view_router|items %} > > +! > > +router bgp {{ router_config.asn }} view {{ view_id }} > > +{{ bgp_router(router_config) -}} > > +exit > > +{% endfor %} > > [..]