From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F15BFFC3C for ; Mon, 24 Jul 2023 15:59:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C9344FA20 for ; Mon, 24 Jul 2023 15:59:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 24 Jul 2023 15:59:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 016084265D for ; Mon, 24 Jul 2023 15:59:24 +0200 (CEST) Date: Mon, 24 Jul 2023 15:59:23 +0200 From: Wolfgang Bumiller To: Lukas Wagner Cc: pve-devel@lists.proxmox.com Message-ID: References: <20230720143236.652292-1-l.wagner@proxmox.com> <20230720143236.652292-43-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230720143236.652292-43-l.wagner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.116 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v4 pve-manager 42/69] test: fix names of .PHONY targets X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jul 2023 13:59:55 -0000 this one I applied On Thu, Jul 20, 2023 at 04:32:09PM +0200, Lukas Wagner wrote: > They need to have the same name as the target. > Took the opportunity to move the .PHONY right next to the target recipe, > so that mistakes like these are hopefully easier caught. > > Signed-off-by: Lukas Wagner > --- > test/Makefile | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/test/Makefile b/test/Makefile > index 670a3611..cccdc1c9 100644 > --- a/test/Makefile > +++ b/test/Makefile > @@ -4,29 +4,35 @@ all: > > export PERLLIB=.. > > -.PHONY: check balloon-test replication-test mail-test vzdump-test > +.PHONY: check > check: test-replication test-balloon test-mail test-vzdump test-osd > > +.PHONY: test-balloon > test-balloon: > ./balloontest.pl > > +.PHONY: test-replication > test-replication: replication1.t replication2.t replication3.t replication4.t replication5.t replication6.t > > replication%.t: replication_test%.pl > ./$< > > +.PHONY: test-mail > test-mail: > ./mail_test.pl > > +.PHONY: test-vzdump > test-vzdump: test-vzdump-guest-included test-vzdump-new > > -.PHONY: test-vzdump-guest-included test-vzdump-new > +.PHONY: test-vzdump-guest-included > test-vzdump-guest-included: > ./vzdump_guest_included_test.pl > > +.PHONY: test-vzdump-new > test-vzdump-new: > ./vzdump_new_test.pl > > +.PHONY: test-osd > test-osd: > ./OSD_test.pl > > -- > 2.39.2