From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8D5E11FF137 for ; Tue, 31 Mar 2026 10:29:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 415FF13356; Tue, 31 Mar 2026 10:30:01 +0200 (CEST) Date: Tue, 31 Mar 2026 10:29:27 +0200 From: Gabriel Goller To: Thomas Lamprecht Subject: Re: applied: [PATCH manager/network/proxmox{-ve-rs,-perl-rs} v8 00/21] Generate frr config using jinja templates and rust types Message-ID: Mail-Followup-To: Thomas Lamprecht , pve-devel@lists.proxmox.com References: <20260327150127.545193-1-g.goller@proxmox.com> <177471674432.3099145.14191595895230112822.b4-ty@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <177471674432.3099145.14191595895230112822.b4-ty@proxmox.com> User-Agent: NeoMutt/20241002-35-39f9a6 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774945712099 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.601 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VD3HGFP4CVU4S5JSFFHEOFMIPOHHXAUR X-Message-ID-Hash: VD3HGFP4CVU4S5JSFFHEOFMIPOHHXAUR X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 28.03.2026 17:55, Thomas Lamprecht wrote: > On Fri, 27 Mar 2026 16:01:03 +0100, Gabriel Goller wrote: > > Previously we generated the frr config using one big perl hash, where every > > controller-plugin and zone-plugin would push their stuff. This is not pretty > > and also tricky to unite with our new rust-based fabrics. Furthermore the only > > way to edit or override the frr config is currently the frr.conf.local file, > > which is merged with the perl-hash in a very janky manner, which has sprouted > > numerous forum threads. The main problem with the frr.conf.local is the limited > > control which the user has as to where the override or additional config gets > > placed. There are also a few config overrides or additions to frr.conf.local > > that are currently impossible or generate invalid frr config. > > > > [...] > > Applied the following parts, thanks! > > proxmox-ve-rs: > [1/9] ve-config: firewall: cargo fmt > commit: 5901f899a77eb853e02dfef33eac1b07f826e7b6 > [2/9] frr: add proxmox-frr-templates package that contains templates > commit: 7d912a192d070d7e68b1e6c00b70a9cad1256ad0 > [3/9] ve-config: remove FrrConfigBuilder struct > commit: 4712a934875e117144975b11d2b24f7185990adc > [4/9] sdn-types: support variable-length NET identifier > commit: c6c1be318e1f8941e31abf5580f25b519ee2dd12 > [5/9] frr: add template serializer and serialize fabrics using templates > commit: 1ca7bb01f6bd175c4b4496b7146bd13bc113a25d > [6/9] frr: add isis configuration and templates > commit: 4198f041b5f7c70a66f2c60885d3d3858946186b > [7/9] frr: support custom frr configuration lines > commit: 9cdffc5eab293455c075c17c3d21b28200a5d048 > [8/9] frr: add bgp support with templates and serialization > commit: 900291179b1c0ee12d67d8fbef429bbd7b97958b > [9/9] frr: enable minijinja strict undefined behavior mode > commit: e97efc0574479b9e7ca0a75147f65627dd34caf5 Note that patch 10 is still in the approval queue!