From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id AB3791FF15F
	for <inbox@lore.proxmox.com>; Mon,  7 Oct 2024 11:52:11 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 4C62A3B0E4;
	Mon,  7 Oct 2024 11:52:36 +0200 (CEST)
Date: Mon, 7 Oct 2024 11:52:02 +0200
From: Christoph Heiss <c.heiss@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>
Message-ID: <uelwwno57upolnivifvljitln7eiie24dokw2cagrt5cllx27i@egnwcqjkabzx>
References: <20241007092218.723938-1-c.heiss@proxmox.com>
 <20241007092218.723938-4-c.heiss@proxmox.com>
 <7cb448b4-a68a-41ea-b874-5bc1bff97140@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <7cb448b4-a68a-41ea-b874-5bc1bff97140@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.030 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH installer 3/3] auto-installer: raise minimum
 root password length to 8 characters
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Thanks for the review!

On Mon, Oct 07, 2024 at 11:49:02AM GMT, Stefan Hanreich wrote:
> On 10/7/24 11:22, Christoph Heiss wrote:
[..]
> > @@ -309,6 +310,10 @@ fn verify_root_password_settings(answer: &Answer) -> Result<()> {
> >      } else if answer.global.root_password.is_none() && answer.global.root_password_hashed.is_none()
> >      {
> >          bail!("One of `global.root_password` or `global.root_password_hashed` must be set");
> > +    } else if answer.global.root_password.is_some()
> > +        && answer.global.root_password.as_ref().map(|s| s.len()) < Some(ROOT_PASSWORD_MIN_LENGTH)
> > +    {
> > +        bail!("`global.root_password` must be at least {ROOT_PASSWORD_MIN_LENGTH} characters long");
> >      } else {
> >          Ok(())
> >      }
>
> maybe match is better at this point?
>
> Something like
>
> match (answer.global.root_password, answer.global.root_password_hashed) {
>   [..]
>   (Some(password), _) if password.len() < ROOT_PASSWORD_MIN_LENGTH,
>   [..]
> }
>

I'll rework it a bit, match definitely seems like the better fit here!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel