From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 772511FF2CA for ; Tue, 23 Jul 2024 13:36:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6A7391E3E; Tue, 23 Jul 2024 13:37:11 +0200 (CEST) Date: Tue, 23 Jul 2024 13:37:07 +0200 From: Christoph Heiss To: Aaron Lauterer Message-ID: References: <20240718134905.1177775-1-c.heiss@proxmox.com> <20240718134905.1177775-12-c.heiss@proxmox.com> <4b74a294-7897-4499-a707-161a760baf1d@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [crates.io] Subject: Re: [pve-devel] [PATCH installer v2 11/17] auto-installer: tests: replace manual panic!() with assert_eq!() X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Tue, Jul 23, 2024 at 01:04:06PM GMT, Aaron Lauterer wrote: > > I quickly compared both variants and realized again, that with the panic, we > can pretty debug print the structs, making it quite a bit easier to compare > the expected result to the actual one. Yep, that's right. Seems I've missed that. > > With the output we get from `assert_eq` it can be very cumbersome to > actually see the diff and why the test failed since the data structures can > be quite large. > > Instead of hacking or own pretty print, we could maybe think about using > https://crates.io/crates/pretty_assertions As discussed offline, I think that this is definitely the way to go. Especially when keeping in mind that these tests are going to grow with ~every auto-installer feature. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel