From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9A5B71FF13E for ; Fri, 20 Mar 2026 11:41:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7F2F214BE7; Fri, 20 Mar 2026 11:41:52 +0100 (CET) Date: Fri, 20 Mar 2026 11:41:16 +0100 From: Gabriel Goller To: Wolfgang Bumiller Subject: Re: [PATCH proxmox-ve-rs v6 05/20] frr: add template serializer and serialize fabrics using templates Message-ID: Mail-Followup-To: Wolfgang Bumiller , pve-devel@lists.proxmox.com References: <20260312142732.370403-1-g.goller@proxmox.com> <20260312142732.370403-6-g.goller@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20241002-35-39f9a6 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774003233585 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UHLA7GYOWQGGASCWDVDBSJLBQPWAKDPP X-Message-ID-Hash: UHLA7GYOWQGGASCWDVDBSJLBQPWAKDPP X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 19.03.2026 11:32, Wolfgang Bumiller wrote: > On Thu, Mar 12, 2026 at 03:26:41PM +0100, Gabriel Goller wrote: > > Add a new serializer which uses only the builtin (include_str!) templates from > > the `proxmox-frr-templates` package in `/usr/share/proxmox-frr/templates` to > > generate the frr config file. Also update the `build_fabric` function and the > > tests accordingly. > > > > Use the `phf` crate to store them in a const map. > > ^ This is the only thing I have an issue with in the `proxmox-ve-rs` > part of this series, but it's quite a lot, so could have easily missed > things. > > A `LazyLock` or `sortable!()`+`binary_serach` should be fine here IMO. > It's a very tiny map. Done. Thanks for the review!