From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 80BF620EC91 for ; Tue, 30 Apr 2024 11:24:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 834A71FE13; Tue, 30 Apr 2024 11:24:24 +0200 (CEST) Date: Tue, 30 Apr 2024 11:23:51 +0200 From: Wolfgang Bumiller To: Fiona Ebner Message-ID: References: <20240430075343.39367-1-w.bumiller@proxmox.com> <0c6b8981-11cf-4f5e-8567-25c0f8e25ffe@proxmox.com> <4qssgd7wmmrlahcxe5j6tqmfonvv3a4ye3tnebrkyegmk77n55@3gxmtkrgghip> <21017c63-9c3c-48ea-8152-df5c66fa1a0c@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <21017c63-9c3c-48ea-8152-df5c66fa1a0c@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.086 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH storage 1/2] don't bail on whitespaces in backing devices X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Tue, Apr 30, 2024 at 11:13:02AM +0200, Fiona Ebner wrote: > Am 30.04.24 um 10:38 schrieb Wolfgang Bumiller: > > On Tue, Apr 30, 2024 at 10:14:13AM +0200, Fiona Ebner wrote: > >> > >> So the returned $parent will now just be undef if it contains > >> whitespaces, even though there is a parent. Can't that cause issues > >> further down the line? If it's fine, a comment with the rationale would > >> be nice. > >> > >> Or should we rather allow whitespaces while matching and return it > >> properly? Or are there any issues with proper escaping then? > > > > I was a bit too quick on the send trigger there, but it should be fine > > IMO: > > > > - where we do run into this issue, we never use/need/care about the parent > > Maybe this part of the function could be guarded by wantarray already, > so callers caring only about the size don't even get there? But I > suppose we do notice other unexpected things earlier by always doing the > additional checks, so maybe it's better like it is right now. Unfortunately a lot of callers do also care about the format, specifically the import code, where this causes issues, so a `wantarray` check won't help there. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel