From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 28974BABD5 for ; Fri, 15 Dec 2023 13:06:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 028181E53 for ; Fri, 15 Dec 2023 13:06:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 15 Dec 2023 13:06:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0D9AD479E7 for ; Fri, 15 Dec 2023 13:06:30 +0100 (CET) Date: Fri, 15 Dec 2023 13:06:29 +0100 From: Christoph Heiss To: Maximiliano Sandoval Cc: pve-devel@lists.proxmox.com Message-ID: References: <20231121151025.233224-1-m.sandoval@proxmox.com> <20231121151025.233224-3-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231121151025.233224-3-m.sandoval@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH installer v2 2/7] gui: expand ip address Gtk3::Entry X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Dec 2023 12:06:31 -0000 On Tue, Nov 21, 2023 at 04:10:20PM +0100, Maximiliano Sandoval wrote: > > This accounts for the different layout set in the previous commit. What commit is meant here exactly? The previous patch in this series (aka. the first) does not change any layout as it's a simple code move, right? > > Signed-off-by: Maximiliano Sandoval > --- > proxinstall | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/proxinstall b/proxinstall > index 8f40234..a5de06c 100755 > --- a/proxinstall > +++ b/proxinstall > @@ -308,7 +308,7 @@ sub create_cidr_inputs { > > my $ip_el = Gtk3::Entry->new(); > $ip_el->set_width_chars(28); > - $hbox->pack_start($ip_el, 0, 0, 0); > + $hbox->pack_start($ip_el, 1, 1, 0); > $ip_el->set_text($default_ip); > > $label = Gtk3::Label->new('/'); > -- > 2.39.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >