From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 905FC9A0BF for ; Fri, 17 Nov 2023 10:07:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 736E81E798 for ; Fri, 17 Nov 2023 10:07:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 17 Nov 2023 10:07:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B5E0E43D06 for ; Fri, 17 Nov 2023 10:07:28 +0100 (CET) References: <20230929130203.3902108-1-a.lauterer@proxmox.com> User-agent: mu4e 1.10.7; emacs 29.1 From: Maximiliano Sandoval To: Proxmox VE development discussion Date: Fri, 17 Nov 2023 09:30:55 +0100 In-reply-to: <20230929130203.3902108-1-a.lauterer@proxmox.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager v4 0/3] fix 2515 use size defaults X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2023 09:07:59 -0000 Tested on a 3-node cluster. Set `osd_pool_default_min_size` and `osd_pool_default_size` on ceph.confg to min_size=1 size=2, created a pool using the web UI and it has the correct size after creation. One things I noticed is that if you set them to, for example min_size=3, size=2, no errors will be displayed in the web UI until the creation fails with: Could not set: min_size, size I am not sure if this should be catched a bit earlier in the web UI, in the same way we catch size=1 and prevent the creation of the pool. It is an invalid configuration file after all. Tested `ceph config set X value`. The values in ceph.conf indeed take priority as per the commit message. When the values are not present in ceph.conf, the values from the config DB take preference over the 3/2 default as expected. Tested-by: Maximiliano Sandoval Aaron Lauterer writes: > The main goal of this series is to improve the handling of configured > default size & min_size values when creating a new Ceph Pool in the GUI. > > A new Ceph API endpoint, 'cfg/value', is added. It allows us to fetch > values for config keys that are set either in the config DB of Ceph or > in the ceph.conf file. > > changes since > v3: rebased > > v2: > * API rework has been already applied > * cleaned up JS code to set default values right where we get them from > the API instead of at multiple places in the CephPoolInputPanel > itself. > > Aaron Lauterer (3): > api: ceph: add endpoint to fetch config keys > fix #2515: ui: ceph pool create: use configured defaults for size and > min_size > ui: ceph pool edit: rework with controller and formulas > > PVE/API2/Ceph/Cfg.pm | 82 ++++++++++++++++++++++ > www/manager6/ceph/Pool.js | 144 +++++++++++++++++++++++++++++--------- > 2 files changed, 191 insertions(+), 35 deletions(-) -- Maximiliano