From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 6B1C01FF17C
for <inbox@lore.proxmox.com>; Wed, 25 Jun 2025 15:50:22 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 8D3F21637C;
Wed, 25 Jun 2025 15:50:55 +0200 (CEST)
References: <20250612082318.118153-1-m.sandoval@proxmox.com>
<476107cf-2197-46ba-890c-a7c91aaf636f@proxmox.com>
User-agent: mu4e 1.10.8; emacs 30.1
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Wed, 25 Jun 2025 15:48:30 +0200
In-reply-to: <476107cf-2197-46ba-890c-a7c91aaf636f@proxmox.com>
Message-ID: <s8ozfdwx74x.fsf@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.099 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [params.storage]
Subject: Re: [pve-devel] [PATCH manager v2] fix #4166: restore: add resource
pool selector
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Thomas Lamprecht <t.lamprecht@proxmox.com> writes:
> Am 12.06.25 um 10:23 schrieb Maximiliano Sandoval:
>> The pool selector is only visible when restoring from the
>> Datacenter->{node}->{storage}->Backups panel.
>
> I mean fine for now, but IMO if the user has enough rights then restoring
> to another pool for when overwriting an existing VM might make sense to;
> but that can definitively be an independent change.
>
>>
>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>> ---
>>
>> Differences from v1:
>> - Hide the pool selector when restoring a VM in-place.
>>
>> www/manager6/window/Restore.js | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js
>> index 22900868..6f9c9f2f 100644
>> --- a/www/manager6/window/Restore.js
>> +++ b/www/manager6/window/Restore.js
>> @@ -47,6 +47,9 @@ Ext.define('PVE.window.Restore', {
>> if (values.storage) {
>> params.storage = values.storage;
>> }
>> + if (values.pool) {
>> + params.pool = values.pool;
>> + }
>>
>> ['bwlimit', 'cores', 'name', 'memory', 'sockets'].forEach(opt => {
>> if ((values[opt] ?? '') !== '') {
>> @@ -186,6 +189,14 @@ Ext.define('PVE.window.Restore', {
>> fieldLabel: gettext('Source'),
>> },
>> storagesel,
>> + {
>> + xtype: 'pvePoolSelector',
>> + fieldLabel: gettext('Resource Pool'),
>> + name: 'pool',
>> + value: '',
>> + allowBlank: true,
>> + hidden: me.vmid,
>> + },
>
> Should this better get placed in the override section?
>
It could be placed there, however I think it makes sense to put it next
to the storage selector (which could also be argued is an override). I
could add a `emptyText` with value 'From backup configuration' similar
as the storage selector though.
>> {
>> xtype: 'pmxDisplayEditField',
>> name: 'vmid',
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel