From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 7E0371FF0E7 for ; Fri, 10 Jul 2026 11:51:35 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id CC0242131C; Fri, 10 Jul 2026 11:51:34 +0200 (CEST) From: Maximiliano Sandoval To: Dominik Csapak Subject: Re: [PATCH manager v3 1/1] ui: processor edit: allow setting 8 sockets In-Reply-To: (Dominik Csapak's message of "Fri, 10 Jul 2026 10:51:45 +0200") References: <20260710084423.164757-1-m.sandoval@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Fri, 10 Jul 2026 11:50:59 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783677049043 X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QOFQ2MABXBK5WGLIHEBCI2PR46IYC7UM X-Message-ID-Hash: QOFQ2MABXBK5WGLIHEBCI2PR46IYC7UM X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Dominik Csapak writes: > On 7/10/26 10:45 AM, Maximiliano Sandoval wrote: >> Maximiliano Sandoval writes: >> >>> The schema at qemu-server does not limit the socket amount. >>> >>> As per our NUMA documentation [1]: >>> >>>> If the NUMA option is used, it is recommended to set the number of sockets to >>>> the number of nodes of the host system. >>> >>> Nowadays, it is common to find CPU models with 8 NUMA nodes. Two examples are >>> Xeon Platinum 8160 and EPYC 73F3. >>> >>> [1] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_numa >>> >>> Signed-off-by: Maximiliano Sandoval >> The commit title should be " ui: processor edit: allow setting 4 sockets". >> > > IMO both titles don't make sense, since 4 is already allowed before the > patch and yes 8 is allowed afterwards but so is 16,32,etc. Sorry my brain got mangled between emails, i tough the title was "more than 4". > and we don't have to argument with numa in the commit message > e.g. it could be enought explain it like this: > > suggestion: > > ui: processor: edit: remove UI limit on socket count > > The backend imposes no limit on the number of sockets, so the UI > should not either. Remove the arbitrary cap and let users set > socket counts as high as the backend allows. Will send new version. -- Maximiliano