From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AB7F8BACB4 for ; Fri, 15 Dec 2023 15:11:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8B3A437E5 for ; Fri, 15 Dec 2023 15:11:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 15 Dec 2023 15:11:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CEDEF47696 for ; Fri, 15 Dec 2023 15:11:10 +0100 (CET) References: <20231121151025.233224-1-m.sandoval@proxmox.com> <20231121151025.233224-3-m.sandoval@proxmox.com> User-agent: mu4e 1.10.8; emacs 29.1 From: Maximiliano Sandoval To: Christoph Heiss Cc: pve-devel@lists.proxmox.com Date: Fri, 15 Dec 2023 15:08:48 +0100 In-reply-to: Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH installer v2 2/7] gui: expand ip address Gtk3::Entry X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Dec 2023 14:11:41 -0000 Christoph Heiss writes: > On Tue, Nov 21, 2023 at 04:10:20PM +0100, Maximiliano Sandoval wrote: >> >> This accounts for the different layout set in the previous commit. > > What commit is meant here exactly? The previous patch in this series > (aka. the first) does not change any layout as it's a simple code move, > right? > Good catch, in v1 this commit went directly after the commit gui: use basic grid in the network panel which contains the mentioned changes. Should this require a v3? -- Maximiliano