From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 060771FF137 for ; Tue, 17 Mar 2026 09:00:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BAA9D4733; Tue, 17 Mar 2026 09:00:56 +0100 (CET) From: Maximiliano Sandoval To: Thomas Lamprecht Subject: Re: [PATCH manager v2 5/7] ui: qga: add checkbox for guest-fsfreeze In-Reply-To: <949ba54f-e58b-4535-b103-9840e0380298@proxmox.com> (Thomas Lamprecht's message of "Mon, 16 Mar 2026 22:41:23 +0100") References: <20260313095534.79526-1-m.sandoval@proxmox.com> <20260313095534.79526-6-m.sandoval@proxmox.com> <949ba54f-e58b-4535-b103-9840e0380298@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Tue, 17 Mar 2026 09:00:51 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773734410589 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.947 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2H6KSQN7QWCS52QYQOXABMKRA5W6J2LI X-Message-ID-Hash: 2H6KSQN7QWCS52QYQOXABMKRA5W6J2LI X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thomas Lamprecht writes: > Am 13.03.26 um 10:55 schrieb Maximiliano Sandoval: >> We re-use the same components from the 'freeze-fs-on-backup' checkbox >> but without referencing that this only affects backups. >> >> Signed-off-by: Maximiliano Sandoval >> --- >> www/manager6/form/AgentFeatureSelector.js | 30 +++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> >> diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js >> index b64837b7..36e5bd8a 100644 >> --- a/www/manager6/form/AgentFeatureSelector.js >> +++ b/www/manager6/form/AgentFeatureSelector.js >> @@ -21,6 +21,30 @@ Ext.define('PVE.form.AgentFeatureSelector', { >> }, >> disabled: true, >> }, >> + { >> + xtype: 'proxmoxcheckbox', >> + boxLabel: gettext( >> + 'Freeze/thaw guest filesystems during certain operations for consistency', >> + ), >> + name: 'guest-fsfreeze', >> + reference: 'guest_fsfreeze', >> + bind: { >> + disabled: '{!enabled.checked}', >> + }, >> + disabled: true, >> + uncheckedValue: '0', >> + defaultValue: '1', >> + }, >> + { >> + xtype: 'displayfield', >> + userCls: 'pmx-hint', >> + value: gettext( >> + 'Freeze/thaw for guest filesystems disabled. This can lead to inconsistent disk images after performing certain operations.', > > very ambiguous wording - what operations? Commit message doesn't give > any hints either. Is there at least a docs change for users to learn > what actual operations this will happen? The modes are documented at [pve-admin] which is right after where the "Help" button in the dialog points to, however, the online documentation has not been updated to contain [docs#862cd43b0]. Given that it is five operation, some with conditionals, I opted to not give a full explanation here. [pve-admin] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#qm_qga_fsfreeze [docs#862cd43b0] https://git.proxmox.com/?p=pve-docs.git;a=commitdiff;h=862cd43b09245de212332bc3b9b03dae0de7ccb8 > btw. this series could have been like three, maybe four commits, > some semantic separation is good, but not every tiny clean-up is > a dedicated semantic change. > >> + ), >> + bind: { >> + hidden: '{guest_fsfreeze.checked}', >> + }, >> + }, >> { >> xtype: 'displayfield', >> userCls: 'pmx-hint', >> @@ -75,6 +99,9 @@ Ext.define('PVE.form.AgentFeatureSelector', { >> if (PVE.Parser.parseBoolean(values['freeze-fs-on-backup'])) { >> delete values['freeze-fs-on-backup']; >> } >> + if (PVE.Parser.parseBoolean(values['guest-fsfreeze'])) { >> + delete values['guest-fsfreeze']; >> + } >> >> const agentstr = PVE.Parser.printPropertyString(values, 'enabled'); >> return { agent: agentstr }; >> @@ -85,6 +112,9 @@ Ext.define('PVE.form.AgentFeatureSelector', { >> if (!Ext.isDefined(res['freeze-fs-on-backup'])) { >> res['freeze-fs-on-backup'] = 1; >> } >> + if (!Ext.isDefined(res['guest-fsfreeze'])) { >> + res['guest-fsfreeze'] = 1; >> + } >> >> this.callParent([res]); >> }, -- Maximiliano