From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8BF15931F1 for ; Mon, 19 Feb 2024 11:35:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6D6421D486 for ; Mon, 19 Feb 2024 11:35:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 19 Feb 2024 11:35:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7DAF9435A1 for ; Mon, 19 Feb 2024 11:35:31 +0100 (CET) References: <20240219102453.240492-1-m.sandoval@proxmox.com> User-agent: mu4e 1.10.8; emacs 29.1 From: Maximiliano Sandoval To: Maximiliano Sandoval Cc: pve-devel@lists.proxmox.com Date: Mon, 19 Feb 2024 11:34:55 +0100 In-reply-to: <20240219102453.240492-1-m.sandoval@proxmox.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-SPAM-LEVEL: Spam detection results: 0 AWL 0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager] fix-5251: login: set autocomplete on password and user X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Feb 2024 10:35:32 -0000 I sent this twice by mistake and the commit titles are wrong. Will send a v2. Maximiliano Sandoval writes: > By default they have 'autocomplete=off'. From [1]: > > > In most modern browsers, setting autocomplete to "off" will not > > prevent a password manager from asking the user if they would like to > > save username and password information, or from automatically filling > > in those values in a site's login form. See the autocomplete > > attribute and login fields [2]. > > [1] https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete > [2] https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#the_autocomplete_attribute_and_login_fields > > Signed-off-by: Maximiliano Sandoval -- Maximiliano